Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 6 pull requests #69848

Closed
wants to merge 37 commits into from
Closed

Commits on Mar 3, 2020

  1. Configuration menu
    Copy the full SHA
    a755d8d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    612d375 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    5892d0d View commit details
    Browse the repository at this point in the history
  4. formatting

    GuillaumeGomez committed Mar 3, 2020
    Configuration menu
    Copy the full SHA
    71b9512 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    6ffe9f3 View commit details
    Browse the repository at this point in the history

Commits on Mar 4, 2020

  1. Permit attributes on 'if' expressions

    Previously, attributes on 'if' expressions (e.g. #[attr] if true {})
    were disallowed during parsing. This made it impossible for macros to
    perform any custom handling of such attributes (e.g. stripping them
    away), since a compilation error would be emitted before they ever had a
    chance to run.
    
    This PR permits attributes on 'if' expressions ('if-attrs' from here on).
    Both built-in attributes (e.g. `#[allow]`, `#[cfg]`) are supported.
    
    We still do *not* accept attributes on 'other parts' of an if-else
    chain. That is, the following code snippet still fails to parse:
    
    ```rust
    if true {} #[attr] else if false {} else #[attr] if false {} #[attr]
    else {}
    ```
    Aaron1011 committed Mar 4, 2020
    Configuration menu
    Copy the full SHA
    f63b88c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e912d9d View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    e9ec47b View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    9a299e4 View commit details
    Browse the repository at this point in the history
  5. Remove recovery test

    Aaron1011 committed Mar 4, 2020
    Configuration menu
    Copy the full SHA
    b00f674 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    e11cdfd View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    7f19358 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    1b681d6 View commit details
    Browse the repository at this point in the history
  9. Extent pretty-print test

    Aaron1011 committed Mar 4, 2020
    Configuration menu
    Copy the full SHA
    37c2c38 View commit details
    Browse the repository at this point in the history
  10. Fix tabs

    Aaron1011 committed Mar 4, 2020
    Configuration menu
    Copy the full SHA
    66b152c View commit details
    Browse the repository at this point in the history
  11. Update stderr

    Aaron1011 committed Mar 4, 2020
    Configuration menu
    Copy the full SHA
    e50fd5a View commit details
    Browse the repository at this point in the history

Commits on Mar 8, 2020

  1. Configuration menu
    Copy the full SHA
    0468929 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    938f852 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    4971d03 View commit details
    Browse the repository at this point in the history
  4. Fix typo

    Co-Authored-By: bjorn3 <[email protected]>
    RalfJung and bjorn3 committed Mar 8, 2020
    Configuration menu
    Copy the full SHA
    85e1466 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    ed3014a View commit details
    Browse the repository at this point in the history

Commits on Mar 9, 2020

  1. Add test for issue-54239

    JohnTitor committed Mar 9, 2020
    Configuration menu
    Copy the full SHA
    af0c44c View commit details
    Browse the repository at this point in the history
  2. Add test for issue-57200

    JohnTitor committed Mar 9, 2020
    Configuration menu
    Copy the full SHA
    fc8be08 View commit details
    Browse the repository at this point in the history
  3. Add test for issue-57201

    JohnTitor committed Mar 9, 2020
    Configuration menu
    Copy the full SHA
    437c07f View commit details
    Browse the repository at this point in the history
  4. Add test for issue-60473

    JohnTitor committed Mar 9, 2020
    Configuration menu
    Copy the full SHA
    0005f29 View commit details
    Browse the repository at this point in the history
  5. Add test for issue-64620

    JohnTitor committed Mar 9, 2020
    Configuration menu
    Copy the full SHA
    95d4785 View commit details
    Browse the repository at this point in the history
  6. Add test for issue-67166

    JohnTitor committed Mar 9, 2020
    Configuration menu
    Copy the full SHA
    579ce86 View commit details
    Browse the repository at this point in the history
  7. Use slices in preference to 0-terminated strings

    Additionally whenever possible match C API provided by the LLVM.
    tmiasko committed Mar 9, 2020
    Configuration menu
    Copy the full SHA
    58303b7 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    e54a829 View commit details
    Browse the repository at this point in the history
  9. unix: Don't override existing SIGSEGV/BUS handlers

    Although `stack_overflow::init` runs very early in the process, even
    before `main`, there may already be signal handlers installed for things
    like the address sanitizer. In that case, just leave it alone, and don't
    bother trying to allocate our own signal stacks either.
    cuviper committed Mar 9, 2020
    Configuration menu
    Copy the full SHA
    676b9bc View commit details
    Browse the repository at this point in the history
  10. Add FIXMEs

    JohnTitor committed Mar 9, 2020
    Configuration menu
    Copy the full SHA
    ef98ec0 View commit details
    Browse the repository at this point in the history
  11. Rollup merge of rust-lang#69201 - Aaron1011:feature/permit-if-attr, r…

    …=Centril
    
    Permit attributes on 'if' expressions
    
    Previously, attributes on 'if' expressions (e.g. `#[attr] if true {}`)
    were disallowed during parsing. This made it impossible for macros to
    perform any custom handling of such attributes (e.g. stripping them
    away), since a compilation error would be emitted before they ever had a
    chance to run.
    
    This PR permits attributes on 'if' expressions ('if-attrs' from here on).
    Both built-in attributes (e.g. `#[allow]`, `#[cfg]`) and proc-macro attributes are supported.
    
    We still do *not* accept attributes on 'other parts' of an if-else
    chain. That is, the following code snippet still fails to parse:
    
    ```rust
    if true {} #[attr] else if false {} else #[attr] if false {} #[attr]
    else {}
    ```
    
    Closes rust-lang#68618
    Centril authored Mar 9, 2020
    Configuration menu
    Copy the full SHA
    32c749e View commit details
    Browse the repository at this point in the history
  12. Rollup merge of rust-lang#69402 - GuillaumeGomez:extend-search, r=kin…

    …nison
    
    Extend search
    
    I realized that when looking for "struct:String" in the rustdoc search for example, the "in arguments" and "returned" tabs were always empty. After some investigation, I realized it was because we only provided the name, and not the type, making it impossible to pass the "type filtering" check.
    
    To resolve this, I added the type alongside the name. Note for the future: we could improve this by instead only registering the path id and use the path dictionary directly. The only problem with that solution (which I already tested) is that it becomes complicated for types in other crates. It'd force us to handle both case with an id and a case with `(name, type)`. I found the current PR big enough to not want to provide it directly. However, I think this is definitely worth it to make it work this way in the future.
    
    About the two tests I added: they don't have much interest except checking that we actually have something returned in the search in the cases of a type filtering with and without literal search.
    
    I also had to update a bit the test script to add the new locally global (haha) variable I created (`NO_TYPE_FILTER`). I added this variable to make the code easier to read than just "-1".
    
    r? @kinnison
    
    cc @ollie27
    Centril authored Mar 9, 2020
    Configuration menu
    Copy the full SHA
    3b1ad4f View commit details
    Browse the repository at this point in the history
  13. Rollup merge of rust-lang#69685 - cuviper:soft-segv, r=sfackler

    unix: Don't override existing SIGSEGV/BUS handlers
    
    Although `stack_overflow::init` runs very early in the process, even
    before `main`, there may already be signal handlers installed for things
    like the address sanitizer. In that case, just leave it alone, and don't
    bother trying to allocate our own signal stacks either.
    
    Fixes rust-lang#69524.
    Centril authored Mar 9, 2020
    Configuration menu
    Copy the full SHA
    839a06d View commit details
    Browse the repository at this point in the history
  14. Rollup merge of rust-lang#69762 - RalfJung:validity-errors, r=oli-obk

    Ensure that validity only raises validity errors
    
    For now, only as a debug-assertion (similar to const-prop detecting errors that allocate).
    
    Now includes rust-lang#69646.
    [Relative diff](RalfJung/rust@layout-visitor...RalfJung:validity-errors).
    
    r? @oli-obk
    Centril authored Mar 9, 2020
    Configuration menu
    Copy the full SHA
    1ae39a5 View commit details
    Browse the repository at this point in the history
  15. Rollup merge of rust-lang#69779 - tmiasko:di-cstr, r=nagisa

    librustc_codegen_llvm: Use slices in preference to 0-terminated strings
    
    Additionally whenever possible match C API provided by the LLVM.
    Centril authored Mar 9, 2020
    Configuration menu
    Copy the full SHA
    428daa3 View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    77da717 View commit details
    Browse the repository at this point in the history