librustc_codegen_llvm: Replace deprecated API usage #69940
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @estebank (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
rust-highfive
added
the
S-waiting-on-review
|
@rust-lang/compiler the code changes look good but I am not qualified to accept this LLVM patch. |
|
@estebank Usually I do this: |
|
📌 Commit 24dc2cb has been approved by |
bors
added
S-waiting-on-bors
| pub fn SetUnnamedAddr(global: &'a Value, unnamed: bool) { | ||
| pub fn SetUnnamedAddress(global: &'a Value, unnamed: UnnamedAddr) { | ||
| unsafe { | ||
| LLVMSetUnnamedAddr(global, unnamed as Bool); | ||
| LLVMSetUnnamedAddress(global, unnamed); | ||
| } | ||
| } |
There was a problem hiding this comment.
A bit confused about all of these wrappers, especially the ones that don't have any casts in them.
There was a problem hiding this comment.
It would be good to go through all these wrappers and remove those that don't carry their weight, but IMO that is a clean-up beyond the scope of this PR.
librustc_codegen_llvm: Replace deprecated API usage
Rollup of 8 pull requests Successful merges: - rust-lang#69080 (rustc_codegen_llvm: don't generate any type debuginfo for -Cdebuginfo=1.) - rust-lang#69940 (librustc_codegen_llvm: Replace deprecated API usage) - rust-lang#69942 (Increase verbosity when suggesting subtle code changes) - rust-lang#69968 (rustc: keep upvars tupled in {Closure,Generator}Substs.) - rust-lang#70123 (Ensure LLVM is in the link path for rustc tools) - rust-lang#70159 (Update the bundled wasi-libc with libstd) - rust-lang#70233 (resolve: Do not resolve visibilities on proc macro definitions twice) - rust-lang#70286 (Miri error type: remove UbExperimental variant) Failed merges: r? @ghost
No description provided.