-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HACK] metadata/rmeta: skip sorting impls by DefPathHash
es.
#70462
Conversation
(rust_highfive has picked a reviewer for you, use r? to override) |
@bors try @rust-timer queue |
Awaiting bors try build completion |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@bors try (oops, started the other build too soon) |
⌛ Trying commit d6b49f9 with merge 335898da9076089c34ec0596e12cc7de600ff03b... |
( |
☀️ Try build successful - checks-azure |
Queued 335898da9076089c34ec0596e12cc7de600ff03b with parent 697d6b3, future comparison URL. |
Finished benchmarking try commit 335898da9076089c34ec0596e12cc7de600ff03b, comparison URL. |
Comparison between "this PR" and "this PR + empty commit". Nothing I've looked at has any query count differences, which is nice, but there's still a lot of noise from codegen/LLVM, so that needs to be looked into separately. I suppose I was wrong to assume that the query counts and noisy codegen/LLVM were related. |
r? @ghost |
See #69060 (comment) for some background.
I'm mostly opening this to do some experimentation (which will require multiple perf runs using the same base, so I'll probably start try builds in parallel using a second PR).
I'd prefer the solution described in #69060 (comment), as it should result in better accuracy as well, but that's more work than this quick hack, at least for testing purposes.
cc @nikomatsakis @michaelwoerister @Mark-Simulacrum