Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clarify hir_id <-> node_id method names #70480

Merged
merged 1 commit into from
Mar 28, 2020
Merged

Conversation

lcnr
Copy link
Contributor

@lcnr lcnr commented Mar 27, 2020

resolves 2 FIXME.

r? @eddyb

@eddyb
Copy link
Member

eddyb commented Mar 27, 2020

@bors r+ Thanks!

@bors
Copy link
Contributor

bors commented Mar 27, 2020

📌 Commit 37603f4 has been approved by eddyb

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Mar 27, 2020
Centril added a commit to Centril/rust that referenced this pull request Mar 27, 2020
clarify hir_id <-> node_id method names

resolves 2 FIXME.

r? @eddyb
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 28, 2020
Rollup of 5 pull requests

Successful merges:

 - rust-lang#70345 (Remove `no_integrated_as` mode.)
 - rust-lang#70434 (suggest `;` on expr `mac!()` which is good as stmt `mac!()`)
 - rust-lang#70457 (non-exhastive diagnostic: add note re. scrutinee type)
 - rust-lang#70478 (Refactor type_of for constants)
 - rust-lang#70480 (clarify hir_id <-> node_id method names)

Failed merges:

r? @ghost
@bors bors merged commit a023e61 into rust-lang:master Mar 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants