Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reduce rustc_attr usage in places #70526

Merged
merged 1 commit into from
Mar 29, 2020
Merged

reduce rustc_attr usage in places #70526

merged 1 commit into from
Mar 29, 2020

Conversation

Centril
Copy link
Contributor

@Centril Centril commented Mar 29, 2020

This cleans up some unused rustc_attr dependencies.

@rust-highfive
Copy link
Collaborator

r? @cramertj

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 29, 2020
@eddyb
Copy link
Member

eddyb commented Mar 29, 2020

@bors r+

@bors
Copy link
Contributor

bors commented Mar 29, 2020

📌 Commit 59a6970 has been approved by eddyb

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 29, 2020
@bors
Copy link
Contributor

bors commented Mar 29, 2020

⌛ Testing commit 59a6970 with merge 645a105a1c544559c81e57a6840f5cb934ff962d...

@Centril
Copy link
Contributor Author

Centril commented Mar 29, 2020

@bors retry

bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 29, 2020
Rollup of 3 pull requests

Successful merges:

 - rust-lang#70140 (Add Result<Result<T, E>, E>::flatten -> Result<T, E>)
 - rust-lang#70526 (reduce `rustc_attr` usage in places)
 - rust-lang#70527 (Update LLVM submodule)

Failed merges:

r? @ghost
@bors bors merged commit b4491e5 into rust-lang:master Mar 29, 2020
@Centril Centril deleted the less-attr branch March 29, 2020 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants