Rollup of 6 pull requests #72379
Closed
Rollup of 6 pull requests #72379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g an error. This way the hir is "valid" and we can remove one more call to `opt_node_id_to_hir_id` but an error is still emitted. This is another partial fix for rust-lang#71104
This was supposed to land as part of rust-lang#72227. (I wish `git push` would abort when you have uncommited changes.)
Suggest fixes and add error recovery for `use foo::self` Fixes rust-lang#63741. I have implemented 2 suggestions on how to fix a `use foo::self` import, however I feel like showing them both might be too verbose. Additionally, I have also implemented error recovery as [menitoned](rust-lang#63741 (comment)) by @comex. I believe r? @estebank deals with diagnostics.
…h-search-behaviour, r=kinnison Fix going back in history to a search result page on firefox This bug was actually firefox not re-running JS script when you go back in history. To trigger it on the current docs: * Make a search * Pick an element (which isn't on the same page as the current element!) * Go back in history Instead of having the search results, you'll see the normal doc page. You can find a small explanation about it [here](http://web.archive.org/web/20100428053932/http://www.firefoxanswer.com/firefox/672-firefoxanswer.html). r? @kinnison cc @ollie27
…static-morse Continue lowering for unsupported async generator instead of returning an error. This way the hir is "valid" and we can remove one more call to `opt_node_id_to_hir_id` but an error is still emitted. This is another partial fix for rust-lang#71104 r? @eddyb
…king_issue, r=shepmaster split_inclusive: add tracking issue number (72360) Adds tracking issue number ( rust-lang#72360 ) to the unstable feature attributes.
…ulacrum Remove unused dependencies Remove some unused dependencies found while while working on rust-lang#72342.
…owup, r=Amanieu Adjust the zero check in `RawVec::grow`. This was supposed to land as part of rust-lang#72227. (I wish `git push` would abort when you have uncommited changes.) r? @Amanieu
|
@bors r+ rollup=never p=6 |
|
📌 Commit 1841240 has been approved by |
bors
added
the
S-waiting-on-bors
|
⌛ Testing commit 1841240 with merge 468f1a82eefdf8d456a21d6f441d9ff412ff80b0... |
|
💔 Test failed - checks-azure |
bors
added
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
use foo::self#71863 (Suggest fixes and add error recovery foruse foo::self)RawVec::grow. #72366 (Adjust the zero check inRawVec::grow.)Failed merges:
r? @ghost