Beta backport PR #72767 #72842
Closed
Beta backport PR #72767 #72842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(and I want to discourage further use of it if possible.)
…ths. Such splits arise from metadata refs into libstd. This way, we can (in a follow on commit) continue to emit the virtual name into things like the like the StableSourceFileId that ends up in incremetnal build artifacts, while still using the devirtualized file path when we want to access the file. Note that this commit is intended to be a refactoring; the actual fix to the bug in question is in a follow-on commit.
…in the encoded build artifacts. Fix rust-lang#70924.
|
Hm okay, I was thinking to just do this on Monday as part of the stable rollup but if we can get it landed separately that seems even better, since it does seem like it could potentially not pass tests or whatever. @bors r+ p=1 |
|
📌 Commit 0d19fb3 has been approved by |
bors
added
the
S-waiting-on-bors
|
⌛ Testing commit 0d19fb3 with merge 5b9dcf6fa07e6c22b54282ad0fd50009ba77fbdc... |
|
💥 Test timed out |
bors
added
S-waiting-on-review
|
Included in #72883 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Beta backport of PR #72767
I am in the midst of testing the backported version locally, but the cherry-picks were all clean so I'm guessing/hoping this will be trivial