Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle assembler warnings properly #73169

Merged
merged 1 commit into from
Jun 11, 2020
Merged

Conversation

Amanieu
Copy link
Member

@Amanieu Amanieu commented Jun 9, 2020

Previously all inline asm diagnostics were treated as errors, but LLVM sometimes emits warnings and notes as well.

Fixes #73160

r? @petrochenkov

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 9, 2020
@petrochenkov
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented Jun 9, 2020

📌 Commit 5541f68 has been approved by petrochenkov

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 9, 2020
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 11, 2020
Rollup of 7 pull requests

Successful merges:

 - rust-lang#72180 (remove extra space from crate-level doctest names)
 - rust-lang#73012 (Show `SyntaxContext` in formatted `Span` debug output)
 - rust-lang#73097 (Try_run must only be used if toolstate is populated)
 - rust-lang#73169 (Handle assembler warnings properly)
 - rust-lang#73182 (Track span of function in method calls, and use this in #[track_caller])
 - rust-lang#73207 (Clean up E0648 explanation)
 - rust-lang#73230 (Suggest including unused asm arguments in a comment to avoid error)

Failed merges:

r? @ghost
@bors bors merged commit b341115 into rust-lang:master Jun 11, 2020
@cuviper cuviper added this to the 1.46 milestone May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inline assembly warning gets turned into error
5 participants