Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use WASM's saturating casts if they are available #73724

Merged
merged 5 commits into from
Jul 3, 2020
Merged

Use WASM's saturating casts if they are available #73724

merged 5 commits into from
Jul 3, 2020

Commits on Jul 2, 2020

  1. Use WASM's saturating casts if they are available 

    WebAssembly supports saturating floating point to integer casts behind a
target feature. The feature is already available on many browsers.
Beginning with 1.45 Rust will start defining the behavior of floating
point to integer casts to be saturating as well. For this Rust
constructs additional checks on top of the `fptoui` / `fptosi`
instructions it emits. Here we introduce the possibility for the codegen
backend to construct saturating casts itself and only fall back to
constructing the checks ourselves if that is not possible.
    @CryZe
    CryZe committed Jul 2, 2020
    Configuration menu
    Copy the full SHA
    94cd4f1 View commit details
    Browse the repository at this point in the history

  2. Check for feature with pre-interned symbol

    @CryZe
    CryZe committed Jul 2, 2020
    Configuration menu
    Copy the full SHA
    b249029 View commit details
    Browse the repository at this point in the history

  3. Add codegen tests

    @CryZe
    CryZe committed Jul 2, 2020
    Configuration menu
    Copy the full SHA
    4c08451 View commit details
    Browse the repository at this point in the history

  4. Add comments and format the code

    @CryZe
    CryZe committed Jul 2, 2020
    Configuration menu
    Copy the full SHA
    8f8c90e View commit details
    Browse the repository at this point in the history

  5. Address review comments and add UI test

    @CryZe
    CryZe committed Jul 2, 2020
    Configuration menu
    Copy the full SHA
    838c497 View commit details
    Browse the repository at this point in the history