Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#71669: add ui, codegen tests for volatile + nearby int intrinsics #74285

Merged
merged 4 commits into from
Jul 14, 2020
Merged

#71669: add ui, codegen tests for volatile + nearby int intrinsics #74285

merged 4 commits into from
Jul 14, 2020

Conversation

theo-lw
Copy link
Contributor

@theo-lw theo-lw commented Jul 13, 2020

Added some tests for intrinsics. See #71669.

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 13, 2020
@lcnr
Copy link
Contributor

lcnr commented Jul 13, 2020 •
edited
Loading

This is already looking good! ./x.py test tidy is still failing though, so please fix the remaining errors:

tidy check
tidy error: /checkout/src/test/ui/intrinsics/intrinsic-volatile.rs:37: trailing whitespace
Checking which error codes lack tests...
some tidy checks failed
Found 507 error codes
Found 0 error codes with no tests
Done!

@lcnr
Copy link
Contributor

lcnr commented Jul 13, 2020

r? @lcnr

@rust-highfive rust-highfive assigned lcnr and unassigned nikomatsakis Jul 13, 2020
@lcnr
Copy link
Contributor

lcnr commented Jul 13, 2020

@bors r=lcnr rollup=always

Thanks @wangtheo! If you want to squash your commits feel free to do so, I will just reapprove in this case.

@bors
Copy link
Contributor

bors commented Jul 13, 2020

📌 Commit 8df79fc has been approved by lcnr

@bors
Copy link
Contributor

bors commented Jul 13, 2020

🌲 The tree is currently closed for pull requests below priority 20, this pull request will be tested once the tree is reopened

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 13, 2020
Manishearth added a commit to Manishearth/rust that referenced this pull request Jul 13, 2020
@Manishearth
Rollup merge of rust-lang#74285 - wangtheo:issue-71669, r=lcnr
efa9759 
rust-lang#71669: add ui, codegen tests for volatile + nearby int intrinsics

Added some tests for intrinsics. See rust-lang#71669.
@Manishearth Manishearth mentioned this pull request Jul 13, 2020
Closed
Manishearth added a commit to Manishearth/rust that referenced this pull request Jul 13, 2020
@Manishearth
Rollup merge of rust-lang#74285 - wangtheo:issue-71669, r=lcnr
8cdd92d 
rust-lang#71669: add ui, codegen tests for volatile + nearby int intrinsics

Added some tests for intrinsics. See rust-lang#71669.
@Manishearth Manishearth mentioned this pull request Jul 13, 2020
Closed
Manishearth added a commit to Manishearth/rust that referenced this pull request Jul 13, 2020
@Manishearth
Rollup merge of rust-lang#74285 - wangtheo:issue-71669, r=lcnr
0a7bbce 
rust-lang#71669: add ui, codegen tests for volatile + nearby int intrinsics

Added some tests for intrinsics. See rust-lang#71669.
@Manishearth Manishearth mentioned this pull request Jul 13, 2020
Closed
Manishearth added a commit to Manishearth/rust that referenced this pull request Jul 14, 2020
@Manishearth
Rollup merge of rust-lang#74285 - wangtheo:issue-71669, r=lcnr
66d6e11 
rust-lang#71669: add ui, codegen tests for volatile + nearby int intrinsics

Added some tests for intrinsics. See rust-lang#71669.
@Manishearth Manishearth mentioned this pull request Jul 14, 2020
Closed
Manishearth added a commit to Manishearth/rust that referenced this pull request Jul 14, 2020
@Manishearth
Rollup merge of rust-lang#74285 - wangtheo:issue-71669, r=lcnr
2bb4bbf 
rust-lang#71669: add ui, codegen tests for volatile + nearby int intrinsics

Added some tests for intrinsics. See rust-lang#71669.
@Manishearth Manishearth mentioned this pull request Jul 14, 2020
Closed
@Manishearth Manishearth mentioned this pull request Jul 14, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 14, 2020
@bors
Auto merge of rust-lang#74313 - Manishearth:rollup-b55rn6t, r=Manishe…
4a689da 
…arth

Rollup of 8 pull requests

Successful merges:

 - rust-lang#73354 (Update RELEASES.md for 1.45.0)
 - rust-lang#73852 (rustdoc: insert newlines between attributes)
 - rust-lang#73867 (Document the union keyword)
 - rust-lang#74046 (Fix caching issue when building tools.)
 - rust-lang#74123 (clean up E0718 explanation)
 - rust-lang#74147 (rustdoc: Allow linking from private items to private types)
 - rust-lang#74285 (rust-lang#71669: add ui, codegen tests for volatile + nearby int intrinsics)
 - rust-lang#74286 (Added detailed error code explanation for issue E0688 in Rust compiler.)

Failed merges:

r? @ghost
@bors bors merged commit fa4ada1 into rust-lang:master Jul 14, 2020
@good-praxis good-praxis mentioned this pull request Aug 29, 2020
Closed
8 tasks
@cuviper cuviper added this to the 1.46 milestone May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@lcnr lcnr

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.46
Development

Successfully merging this pull request may close these issues.
6 participants
@theo-lw @rust-highfive @lcnr @bors @cuviper @nikomatsakis