-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MinGW: disable self-contained mode when cross compiling #74410
MinGW: disable self-contained mode when cross compiling #74410
Conversation
When cross compiling users have to provide own linker and libraries anyway. Using rust provided MinGW crt objects is harmful here and has no benefits.
(rust_highfive has picked a reviewer for you, use r? to override) |
This hasn't got any response for about three weeks, let's re-assign following GitHub recommendation. |
If we are cross-compiling from Windows (MSVC, or Mingw with different bit-ness) then the Rust-provided linker should work as well? |
📌 Commit 08990e5 has been approved by |
💡 This pull request was already approved, no need to approve it again.
|
📌 Commit 08990e5 has been approved by |
In that case |
☀️ Test successful - checks-actions, checks-azure |
When cross compiling users have to provide own linker and libraries anyway.
Using rust provided MinGW crt objects is harmful here and has no benefits.
cc #68887