Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MinGW: disable self-contained mode when cross compiling #74410

Merged

Conversation

mati865
Copy link
Contributor

@mati865 mati865 commented Jul 16, 2020

When cross compiling users have to provide own linker and libraries anyway.
Using rust provided MinGW crt objects is harmful here and has no benefits.

cc #68887

When cross compiling users have to provide own linker and libraries anyway.
Using rust provided MinGW crt objects is harmful here and has no benefits.
@rust-highfive
Copy link
Collaborator

r? @matthewjasper

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 16, 2020
@crlf0710 crlf0710 added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 31, 2020
@JohnTitor
Copy link
Member

This hasn't got any response for about three weeks, let's re-assign following GitHub recommendation.
r? @petrochenkov

@petrochenkov
Copy link
Contributor

petrochenkov commented Aug 9, 2020

When cross compiling users have to provide own linker and libraries anyway.

If we are cross-compiling from Windows (MSVC, or Mingw with different bit-ness) then the Rust-provided linker should work as well?
I'm all for limiting the self-contained mode, but we may have to partially revert this later if the aforementioned scenarios are used in practice.
@bors r+

@bors
Copy link
Contributor

bors commented Aug 9, 2020

📌 Commit 08990e5 has been approved by petrochenkov

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 9, 2020
@bors
Copy link
Contributor

bors commented Aug 9, 2020

💡 This pull request was already approved, no need to approve it again.

@bors
Copy link
Contributor

bors commented Aug 9, 2020

📌 Commit 08990e5 has been approved by petrochenkov

@mati865
Copy link
Contributor Author

mati865 commented Aug 9, 2020

If we are cross-compiling from Windows (MSVC, or Mingw with different bit-ness) then the Rust-provided linker should work as well?

In that case rust-mingw is not installed so Rust doesn't provide the linker.

@bors
Copy link
Contributor

bors commented Aug 10, 2020

⌛ Testing commit 08990e5 with merge 568f619...

@bors
Copy link
Contributor

bors commented Aug 10, 2020

☀️ Test successful - checks-actions, checks-azure
Approved by: petrochenkov
Pushing 568f619 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 10, 2020
@bors bors merged commit 568f619 into rust-lang:master Aug 10, 2020
@mati865 mati865 deleted the mingw-no-self-contained-when-cross-compiling branch August 10, 2020 07:36
@cuviper cuviper added this to the 1.47.0 milestone May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants