Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustdoc: Always warn when linking from public to private items #74460

Merged
merged 2 commits into from
Jul 23, 2020
Merged

rustdoc: Always warn when linking from public to private items #74460

merged 2 commits into from
Jul 23, 2020

Commits on Jul 22, 2020

  1. rustdoc: Always warn when linking from public to private items 

    Change the logic such that linking from a public to a private item always
triggers intra_doc_link_resolution_failure. Previously, the warning was
not emitted when --document-private-items is passed.

Also don't rely anymore on the item's visibility, which would falsely trigger
the lint now that the check for --document-private-items is gone.
    @dennis-hamester
    dennis-hamester committed Jul 22, 2020
    Configuration menu
    Copy the full SHA
    ed53de0 View commit details
    Browse the repository at this point in the history

  2. rustdoc: Add explanation when linting against public to private item … 

    …links

The additional note helps explaining why the lint was triggered and that
--document-private-items directly influences the link resolution.
    @dennis-hamester
    dennis-hamester committed Jul 22, 2020
    Configuration menu
    Copy the full SHA
    c14641a View commit details
    Browse the repository at this point in the history