Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update stdarch submodule #74482

Merged
merged 1 commit into from
Jul 28, 2020
Merged

Update stdarch submodule #74482

merged 1 commit into from
Jul 28, 2020

Conversation

alexcrichton
Copy link
Member

This commit updates the src/stdarch submodule primarily to include
rust-lang/stdarch#874 which updated and revamped WebAssembly SIMD
intrinsics and renamed WebAssembly atomics intrinsics. This is all
unstable surface area of the standard library so the changes should be
ok here. The SIMD updates also enable SIMD intrinsics to be used by any
program any any time, yay!

cc #74372, a tracking issue I've opened for the stabilization of SIMD
intrinsics

@rust-highfive
Copy link
Collaborator

r? @hanna-kruppe

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive
Copy link
Collaborator

⚠️ Warning ⚠️

  • These commits modify submodules.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 18, 2020
@hanna-kruppe
Copy link
Contributor

The submodule update pulls in rust-lang/stdarch@6a20add, which makes breaking changes to some stable x86(-64) intrinsics. Discussion in the PR (rust-lang/stdarch#868) proposes to do a crater run on the submodule update, which is currently in progress at #73166 so I don't think this PR can be merged yet.

@alexcrichton
Copy link
Member Author

Hm ok, that PR has sat for a few weeks without a lot of activity, but seems ok to wait a little more. If it takes much longer though I think I'll push to revert the breaking change which can be re-landed if crater comes back clean.

@bors
Copy link
Contributor

bors commented Jul 28, 2020

☔ The latest upstream changes (presumably #73265) made this pull request unmergeable. Please resolve the merge conflicts.

alexcrichton added a commit to alexcrichton/stdarch that referenced this pull request Jul 28, 2020
This commit partially reverts rust-lang#868 to restore the intrinsics to their
original implementation to avoid breaking changes. This is done while
rust-lang/rust#73166 is running through crater, and should unblock
rust-lang/rust#74482.
@alexcrichton
Copy link
Member Author

I've posted rust-lang/stdarch#878 to help this move along.

Amanieu pushed a commit to rust-lang/stdarch that referenced this pull request Jul 28, 2020
This commit partially reverts #868 to restore the intrinsics to their
original implementation to avoid breaking changes. This is done while
rust-lang/rust#73166 is running through crater, and should unblock
rust-lang/rust#74482.
This commit updates the src/stdarch submodule primarily to include
rust-lang/stdarch#874 which updated and revamped WebAssembly SIMD
intrinsics and renamed WebAssembly atomics intrinsics. This is all
unstable surface area of the standard library so the changes should be
ok here. The SIMD updates also enable SIMD intrinsics to be used by any
program any any time, yay!

cc rust-lang#74372, a tracking issue I've opened for the stabilization of SIMD
intrinsics
@alexcrichton
Copy link
Member Author

Ok re-r? @hanna-kruppe

This should no longer be a breaking change for x86/x86_64 std::arch

@hanna-kruppe
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented Jul 28, 2020

📌 Commit 83b4930 has been approved by hanna-kruppe

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 28, 2020
@bors
Copy link
Contributor

bors commented Jul 28, 2020

⌛ Testing commit 83b4930 with merge 98efae8...

@bors
Copy link
Contributor

bors commented Jul 28, 2020

☀️ Test successful - checks-actions, checks-azure
Approved by: hanna-kruppe
Pushing 98efae8 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 28, 2020
@bors bors merged commit 98efae8 into rust-lang:master Jul 28, 2020
@alexcrichton alexcrichton deleted the update-stdarch branch July 29, 2020 00:25
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Nov 15, 2020
…sfackler

Fix an intrinsic invocation on threaded wasm

This looks like it was forgotten to get updated in rust-lang#74482 and wasm with
threads isn't built on CI so we didn't catch this by accident.
@cuviper cuviper added this to the 1.47.0 milestone May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants