Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Profiler: reenable atomics after #65214 #75838

Merged
merged 1 commit into from
Aug 25, 2020
Merged

Profiler: reenable atomics after #65214 #75838

merged 1 commit into from
Aug 25, 2020

Conversation

mati865
Copy link
Contributor

@mati865 mati865 commented Aug 23, 2020 •
edited
Loading

No description provided.

@rust-highfive
Copy link
Collaborator

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 23, 2020
@mati865
Copy link
Contributor Author

mati865 commented Aug 24, 2020

r? @Amanieu

@Amanieu
Copy link
Member

Amanieu commented Aug 24, 2020

@bors r+

@bors
Copy link
Contributor

bors commented Aug 24, 2020

📌 Commit 1a9def1 has been approved by Amanieu

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 24, 2020
@bors
Copy link
Contributor

bors commented Aug 24, 2020

⌛ Testing commit 1a9def1 with merge ee2967c88c22164875057a790db83ba5daf4deb2...

@bors
Copy link
Contributor

bors commented Aug 24, 2020

💔 Test failed - checks-azure

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 24, 2020
@mati865
Copy link
Contributor Author

mati865 commented Aug 24, 2020

Seems spurious:

-- Installing: /Users/runner/work/1/s/build/x86_64-apple-darwin/llvm/include/llvm/ADT/BreadthFirstIterator.h
Assertion failed: (timeout != -1), function uv__io_poll, file ../deps/uv/src/unix/kqueue.c, line 231.

@Amanieu
Copy link
Member

Amanieu commented Aug 24, 2020

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 24, 2020
@bors
Copy link
Contributor

bors commented Aug 25, 2020

⌛ Testing commit 1a9def1 with merge 5890563...

@bors
Copy link
Contributor

bors commented Aug 25, 2020

☀️ Test successful - checks-actions, checks-azure
Approved by: Amanieu
Pushing 5890563 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 25, 2020
@bors bors merged commit 5890563 into rust-lang:master Aug 25, 2020
@mati865 mati865 deleted the profiler-atomics branch August 25, 2020 14:11
@cuviper cuviper added this to the 1.47.0 milestone Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Amanieu Amanieu

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.47.0
Development

Successfully merging this pull request may close these issues.
6 participants
@mati865 @rust-highfive @Amanieu @bors @cuviper @nikomatsakis