Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Joshua's CI playground #76797

Closed
wants to merge 8 commits into from
Closed

Joshua's CI playground #76797

wants to merge 8 commits into from

Commits on Sep 16, 2020

  1. Pass --target to lint docs 

    Otherwise, we may not have a standard library built for the native "host" target
of the rustc being run.
    @Mark-Simulacrum
    Mark-Simulacrum committed Sep 16, 2020
    Configuration menu
    Copy the full SHA
    67a5112 View commit details
    Browse the repository at this point in the history

  2. Build rustdoc for cross-compiled targets 

    This isn't an issue for most folks who use x.py dist, which will directly depend
on this. But for x.py build, if we don't properly set target here rustdoc will
not be built.

Currently, there is not a default-on step for generating a rustc for a given
target either, so we will fail to build a rustc as well.
    @Mark-Simulacrum
    Mark-Simulacrum committed Sep 16, 2020
    Configuration menu
    Copy the full SHA
    3c6cf7e View commit details
    Browse the repository at this point in the history

  3. Instructions

    @shepmaster @jyn514
    shepmaster authored and jyn514 committed Sep 16, 2020
    Configuration menu
    Copy the full SHA
    83953c4 View commit details
    Browse the repository at this point in the history

  4. Try building in CI

    @shepmaster @jyn514
    shepmaster authored and jyn514 committed Sep 16, 2020
    Configuration menu
    Copy the full SHA
    03027f0 View commit details
    Browse the repository at this point in the history

  5. Use patched cc

    @shepmaster @jyn514
    shepmaster authored and jyn514 committed Sep 16, 2020
    Configuration menu
    Copy the full SHA
    caaab28 View commit details
    Browse the repository at this point in the history

  6. stage 2?

    @shepmaster @jyn514
    shepmaster authored and jyn514 committed Sep 16, 2020
    Configuration menu
    Copy the full SHA
    a284012 View commit details
    Browse the repository at this point in the history

  7. Debug CI failures

    @jyn514
    jyn514 committed Sep 16, 2020
    Configuration menu
    Copy the full SHA
    78a0931 View commit details
    Browse the repository at this point in the history

  8. Don't generate bootstrap usage unless it's needed 

    Previously, `x.py` would unconditionally run `x.py build` to get the
help message. After rust-lang#76165,
when checking the CI stage was moved into `Config`, that would cause an
assertion failure (but only only in CI!):

```
thread 'main' panicked at 'assertion failed: `(left == right)`
  left: `1`,
 right: `2`', src/bootstrap/config.rs:619:49
```

This changes bootstrap to only generate a help message when it needs
to (when someone passes `--help`).
    @jyn514
    jyn514 committed Sep 16, 2020
    Configuration menu
    Copy the full SHA
    5af35c1 View commit details
    Browse the repository at this point in the history