Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add regression test for wasm bug #77225

Closed
wants to merge 1 commit into from
Closed

Add regression test for wasm bug #77225

wants to merge 1 commit into from

Conversation

rossmacarthur
Copy link
Contributor

Fixes #76281

@rust-highfive
Copy link
Collaborator

r? @Mark-Simulacrum

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 26, 2020
@Mark-Simulacrum
Copy link
Member

Hm, do we have a bisection here? I hesitate to add a test without knowing what PR fixed it.

It looks like you need to add // run-pass to the test to get CI to pass.

@Mark-Simulacrum Mark-Simulacrum added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 30, 2020
@camelid camelid added A-testsuite Area: The testsuite used to check the correctness of rustc O-wasm Target: WASM (WebAssembly), http://webassembly.org/ labels Oct 16, 2020
@camelid
Copy link
Member

camelid commented Oct 16, 2020

@rossmacarthur Could you address the review comments?

@JohnCSimon JohnCSimon added the S-inactive Status: Inactive and waiting on the author. This is often applied to closed PRs. label Nov 3, 2020
@JohnCSimon
Copy link
Member

Pinging from triage: @rossmacarthur
Unfortunately this has been idle for too long and I'm going to close it as inactive, please feel free to reopen when you get the chance to address the build issues and merge conflicts.

@JohnCSimon JohnCSimon closed this Nov 3, 2020
@rossmacarthur rossmacarthur deleted the fix-76281-add-test branch November 27, 2022 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjorn3 bjorn3 bjorn3 left review comments

Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
A-testsuite Area: The testsuite used to check the correctness of rustc O-wasm Target: WASM (WebAssembly), http://webassembly.org/ S-inactive Status: Inactive and waiting on the author. This is often applied to closed PRs. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

rustc hangs when compiling for wasm32
6 participants
@rossmacarthur @rust-highfive @Mark-Simulacrum @camelid @JohnCSimon @bjorn3