Ensure that all LLVM components requested by tests are available on CI #77280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
|
(I've added an intentionally "mistyped" component |
jyn514
added
T-bootstrap
petrochenkov
force-pushed
the
llvmcomp
branch
from
596f600
to
dabf10f
Compare
|
r=me once we confirm the CI breaks on the non-existing component (and fix it :) |
petrochenkov
force-pushed
the
llvmcomp
branch
from
dabf10f
to
5492039
Compare
Excellent. |
petrochenkov
force-pushed
the
llvmcomp
branch
from
5492039
to
9340ee4
Compare
|
@bors r=Mark-Simulacrum rollup |
|
📌 Commit 9340ee4 has been approved by |
bors
added
S-waiting-on-bors
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Sep 30, 2020
…acrum Ensure that all LLVM components requested by tests are available on CI Addresses rust-lang#75064 (comment) I used an environment variable because passing a command line option all the way from CI to compiletest would be just too much hassle for this task. I added a new variable, but any of the already existing ones defined by CI could be used instead. r? @Mark-Simulacrum
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 30, 2020
…as-schievink Rollup of 12 pull requests Successful merges: - rust-lang#77037 (more tiny clippy cleanups) - rust-lang#77233 (BTreeMap: keep an eye out on the size of the main components) - rust-lang#77280 (Ensure that all LLVM components requested by tests are available on CI) - rust-lang#77284 (library: Forward compiler-builtins "mem" feature) - rust-lang#77296 (liveness: Use Option::None to represent absent live nodes) - rust-lang#77322 (Add unstable book docs for `-Zunsound-mir-opts`) - rust-lang#77328 (Use `rtassert!` instead of `assert!` from the child process after fork() in std::sys::unix::process::Command::spawn()) - rust-lang#77331 (Add test for async/await combined with const-generics.) - rust-lang#77338 (Fix typo in alloc vec comment) - rust-lang#77340 (Alloc vec use imported path) - rust-lang#77345 (Add test for issue rust-lang#74761) - rust-lang#77348 (Update books) Failed merges: r? `@ghost`
Amanieu
added a commit
to Amanieu/rust
that referenced
this pull request
Apr 12, 2023
This check was introduced by rust-lang#77280 to ensure that all tests that are filtered by LLVM component are actually tested in CI. However this causes issues for new targets (e.g. rust-lang#101069) where support is only available on the latest LLVM version. This PR restricts the tests to only CI jobs that use the latest LLVM version.
bors
added a commit
that referenced
this pull request
Apr 25, 2023
Allow older LLVM versions to have missing components This check was introduced by #77280 to ensure that all tests that are filtered by LLVM component are actually tested in CI. However this causes issues for new targets (e.g. #101069) where support is only available on the latest LLVM version. This PR restricts the tests to only CI jobs that use the latest LLVM version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #75064 (comment)
I used an environment variable because passing a command line option all the way from CI to compiletest would be just too much hassle for this task.
I added a new variable, but any of the already existing ones defined by CI could be used instead.
r? @Mark-Simulacrum