Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustc_target: Refactor away TargetResult #77580

Merged
merged 2 commits into from
Oct 10, 2020
Merged

rustc_target: Refactor away TargetResult #77580

merged 2 commits into from
Oct 10, 2020

Conversation

petrochenkov
Copy link
Contributor

@petrochenkov petrochenkov commented Oct 5, 2020 •
edited
Loading

Follow-up to #77202.

Construction of a built-in target is always infallible now, so TargetResult is no longer necessary.

The second commit contains some further cleanup based on built-in target construction being infallible.

@petrochenkov
rustc_target: Refactor away TargetResult
021fcbd 
Construction of a built-in target is always infallible now, so `TargetResult` is no longer necessary.
@rust-highfive
Copy link
Collaborator

r? @matthewjasper

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 5, 2020
@petrochenkov petrochenkov mentioned this pull request Oct 5, 2020
Merged
@petrochenkov
rustc_target: Further simplify loading of built-in targets
1444ad7 
using the fact that it is infallible.

JSON roundtrip check on every rustc run is also removed, it's already performed by unit tests.
ehuss
ehuss approved these changes Oct 5, 2020
View reviewed changes
Copy link
Contributor

@ehuss ehuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jyn514 jyn514 added A-target-specs Area: Compile-target specifications T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. C-cleanup Category: PRs that clean code up or issues documenting cleanup. labels Oct 5, 2020
@matthewjasper
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented Oct 9, 2020

📌 Commit 1444ad7 has been approved by matthewjasper

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 9, 2020
@bors
Copy link
Contributor

bors commented Oct 10, 2020

⌛ Testing commit 1444ad7 with merge 0e022fc...

@bors
Copy link
Contributor

bors commented Oct 10, 2020

☀️ Test successful - checks-actions, checks-azure
Approved by: matthewjasper
Pushing 0e022fc to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Oct 10, 2020
@bors bors merged commit 0e022fc into rust-lang:master Oct 10, 2020
@rustbot rustbot added this to the 1.49.0 milestone Oct 10, 2020
@bors bors mentioned this pull request Oct 10, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehuss ehuss ehuss approved these changes

Assignees

@matthewjasper matthewjasper

Labels
A-target-specs Area: Compile-target specifications C-cleanup Category: PRs that clean code up or issues documenting cleanup. merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.49.0
Development

Successfully merging this pull request may close these issues.
7 participants
@petrochenkov @rust-highfive @matthewjasper @bors @ehuss @jyn514 @rustbot