Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for exhaustion in RangeInclusive::contains and slicing #78109

Merged
merged 3 commits into from
Oct 24, 2020
Merged

Check for exhaustion in RangeInclusive::contains and slicing #78109

merged 3 commits into from
Oct 24, 2020

Commits on Oct 19, 2020

  1. Check for exhaustion in RangeInclusive::contains 

    When a range has finished iteration, `is_empty` returns true, so it
should also be the case that `contains` returns false.
    @cuviper
    cuviper committed Oct 19, 2020
    Configuration menu
    Copy the full SHA
    b62b352 View commit details
    Browse the repository at this point in the history

  2. make exhausted RangeInclusive::end_bound return Excluded(end)

    @cuviper
    cuviper committed Oct 19, 2020
    Configuration menu
    Copy the full SHA
    9fd79a3 View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2020

  1. Check for exhaustion in SliceIndex for RangeInclusive

    @cuviper
    cuviper committed Oct 21, 2020
    Configuration menu
    Copy the full SHA
    9202fbd View commit details
    Browse the repository at this point in the history