Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapted trans::common::{block, fn_ctxt, scope_info} to new naming convention. #7848

Closed

Conversation

michaelwoerister
Copy link
Member

The following types are renamed:

block_ => Block
block => @mut Block

fn_ctx_ => FunctionContext
fn_ctx => @mut FunctionContext

scope_info => ScopeInfo

I also tried to convert instances of @mut to &mut or & but a lot of them are blocked by issue #6268, so I left it for some time later.

@michaelwoerister
Copy link
Member Author

Rebased and fixed merge conflicts.

@jdm
Copy link
Contributor

jdm commented Jul 18, 2013

Looks like this needs a rebase again :P

@michaelwoerister
Copy link
Member Author

Done. Probably not the last time. But the merge conflicts are rather easy to resolve.

@huonw
Copy link
Member

huonw commented Jul 21, 2013

@michaelwoerister, needs another rebase!

@michaelwoerister
Copy link
Member Author

Done.

@michaelwoerister
Copy link
Member Author

Is this test failing my fault? It seems to have gone unresponsive.

@jdm
Copy link
Contributor

jdm commented Jul 22, 2013

Aaaaaaaaand rebase required again. The downside of big cleanups :P

@michaelwoerister
Copy link
Member Author

Well, that's what I signed up for here :)

@michaelwoerister
Copy link
Member Author

Well, this one is entirely my fault. I forgot to stage the changes before doing the commit --amend.
I did another rebase and am running make check right now. Sorry for the trouble...

@michaelwoerister
Copy link
Member Author

@jdm Please re-approve.

bors added a commit that referenced this pull request Jul 23, 2013
The following types are renamed:
```rust
block_ => Block
block => @mut Block

fn_ctx_ => FunctionContext
fn_ctx => @mut FunctionContext

scope_info => ScopeInfo
```
I also tried to convert instances of `@mut` to `&mut` or `&` but a lot of them are blocked by issue #6268, so I left it for some time later.
@bors bors closed this Jul 23, 2013
@jdm
Copy link
Contributor

jdm commented Jul 23, 2013

\o/

flip1995 pushed a commit to flip1995/rust that referenced this pull request Oct 21, 2021
Fix doc heading of `transmute_num_to_bytes`

changelog: none
@michaelwoerister michaelwoerister deleted the trans_cleanup_1 branch February 7, 2022 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants