Fix shellcheck error #78666
Fix shellcheck error #78666
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Mark-Simulacrum (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
rust-highfive
added
the
S-waiting-on-review
|
|
jyn514
added
the
T-infra
|
@jyn514 Thanks for review. I revert 5c9db03 and change |
This comment has been minimized.
This comment has been minimized.
sasurau4
force-pushed
the
fix/shellcheck-error
branch
from
c115783
to
48ead07
Compare
|
@rustbot modify labels: +S-waiting-on-review -S-waiting-on-author |
|
r=me with commits squashed, I expect the worst that happens from getting the shebang wrong is a syntax error. |
sasurau4
force-pushed
the
fix/shellcheck-error
branch
from
48ead07
to
5ea028e
Compare
|
@jyn514 I squashed commits |
|
@bors r+ Thanks for the PR! |
|
📌 Commit 5ea028e has been approved by |
bors
added
S-waiting-on-bors
Rollup of 15 pull requests Successful merges: - rust-lang#74979 (`#![deny(unsafe_op_in_unsafe_fn)]` in sys/hermit) - rust-lang#78006 (Use Intra-doc links for std::io::buffered) - rust-lang#78167 (Fix unreachable sub-branch detection in or-patterns) - rust-lang#78514 (Allow using 1/2/3/4 for `x.py setup` options) - rust-lang#78538 (BTreeMap: document a curious assumption in test cases) - rust-lang#78559 (Add LLVM upgrades from 7 to 10 to RELEASES.md) - rust-lang#78666 (Fix shellcheck error) - rust-lang#78705 (Print a summary of which test suite failed) - rust-lang#78726 (Add link to rust website) - rust-lang#78730 (Expand explanation of reverse_bits) - rust-lang#78760 (`deny(invalid_codeblock_attributes)` for rustc_error_codes) - rust-lang#78771 (inliner: Copy unevaluated constants only after successful inlining) - rust-lang#78794 (rustc_expand: use collect_bang helper instead of manual reimplementation) - rust-lang#78795 (The renumber pass is long gone) - rust-lang#78798 (Fixing Spelling Typos) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
| else | ||
| cargo +${TOOLCHAIN} $cmd $@ | ||
| cargo +${TOOLCHAIN} $cmd "$@" |
There was a problem hiding this comment.
These have already been fixed https://github.com/bjorn3/rustc_codegen_cranelift/pull/1109, which hasn't been pulled into rust-lang/rust yet. This is going to conflict when I pull it.
There was a problem hiding this comment.
Pulled as bjorn3/rustc_codegen_cranelift@11dd005.
| @@ -1,3 +1,4 @@ | |||
| #!/usr/bin/env bash | |||
There was a problem hiding this comment.
This file is deliberately not executable. It is only meant to be sourced.
…n514 Fix shellcheck error ## Overview Helps with rust-lang#77290 This pr fix only errors of shellcheck, the result of `git ls-files '*.sh' | xargs shellcheck --severity=error`. Fixing error are following. - https://github.com/koalaman/shellcheck/wiki/SC2148 - https://github.com/koalaman/shellcheck/wiki/SC1008 Disable error following. - https://github.com/koalaman/shellcheck/wiki/SC2068
Overview
Helps with #77290
This pr fix only errors of shellcheck, the result of
git ls-files '*.sh' | xargs shellcheck --severity=error.Fixing error are following.
Disable error following.