Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add core::slice::fill_with #79222

Merged
merged 1 commit into from
Nov 21, 2020
Merged

Add core::slice::fill_with #79222

merged 1 commit into from
Nov 21, 2020

Conversation

yoshuawuyts
Copy link
Member

@yoshuawuyts yoshuawuyts commented Nov 20, 2020 •
edited by m-ou-se
Loading

Tracking issue #79221.

As suggested by @m-ou-se in #70758 (comment) this implements slice::fill_with as a counterpart to slice::fill. This mirrors Vec::resize and Vec::resize_with. Thanks!

r? @m-ou-se

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 20, 2020
m-ou-se
m-ou-se reviewed Nov 20, 2020
View reviewed changes
Copy link
Member

@m-ou-se m-ou-se left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for implementing this!

library/core/src/slice/mod.rs Outdated Show resolved Hide resolved
library/core/src/slice/mod.rs Outdated Show resolved Hide resolved
@m-ou-se m-ou-se added T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. A-slice Area: [T] labels Nov 20, 2020
@m-ou-se
Copy link
Member

m-ou-se commented Nov 20, 2020

@bors r+

@bors
Copy link
Contributor

bors commented Nov 20, 2020

📌 Commit a64d0d4 has been approved by m-ou-se

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 20, 2020
@m-ou-se m-ou-se mentioned this pull request Nov 20, 2020
Closed
2 tasks
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Nov 21, 2020
@Dylan-DPC
Rollup merge of rust-lang#79222 - yoshuawuyts:slice-fill-with, r=m-ou-se
7af4939 
Add `core::slice::fill_with`

Tracking issue rust-lang#79221.

As suggested by `@m-ou-se` in rust-lang#70758 (comment) this implements `slice::fill_with` as a counterpart to `slice::fill`. This mirrors `Vec::resize` and `Vec::resize_with`. Thanks!

r? `@m-ou-se`
@Dylan-DPC-zz Dylan-DPC-zz mentioned this pull request Nov 21, 2020
Closed
@bors
Copy link
Contributor

bors commented Nov 21, 2020

⌛ Testing commit a64d0d4 with merge 29a74e6...

@bors
Copy link
Contributor

bors commented Nov 21, 2020

☀️ Test successful - checks-actions
Approved by: m-ou-se
Pushing 29a74e6 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 21, 2020
@bors bors merged commit 29a74e6 into rust-lang:master Nov 21, 2020
@rustbot rustbot added this to the 1.50.0 milestone Nov 21, 2020
@yoshuawuyts yoshuawuyts deleted the slice-fill-with branch November 21, 2020 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m-ou-se m-ou-se m-ou-se left review comments

@pickfire pickfire pickfire left review comments

Assignees

@m-ou-se m-ou-se

Labels
A-slice Area: [T] merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.50.0
Development

Successfully merging this pull request may close these issues.
6 participants
@yoshuawuyts @m-ou-se @bors @pickfire @rust-highfive @rustbot