std/core docs: fix wrong link in PartialEq #80864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PartialEq doc was attempting to link to [`Eq`] but instead we got a link to `eq`. Disambiguate with "trait@Eq".
|
r? @m-ou-se (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
m-ou-se
reviewed
Jan 10, 2021
|
@ericseppanen can you open an issue? This is a bug in rustdoc for several reasons:
|
jyn514
added
the
A-intra-doc-links
|
It doesn't appear as though the underlying rustdoc behavior is likely to change soon, so I think this is ready to go in, unless someone still feels that |
|
Yep, this looks good to me. Thanks for noticing! @bors r+ rollup |
|
📌 Commit eef9587 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 12, 2021
Rollup of 9 pull requests Successful merges: - rust-lang#79997 (Emit a reactor for cdylib target on wasi) - rust-lang#79998 (Use correct ABI for wasm32 by default) - rust-lang#80042 (Split a func into cold/hot parts, reducing binary size) - rust-lang#80324 (Explain method-call move errors in loops) - rust-lang#80864 (std/core docs: fix wrong link in PartialEq) - rust-lang#80870 (resolve: Simplify built-in macro table) - rust-lang#80885 (rustdoc: Resolve `&str` as `str`) - rust-lang#80904 (Fix small typo) - rust-lang#80923 (Merge different function exits) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PartialEq doc was attempting to link to
[`Eq`]but instead we got a link to`eq`. Disambiguate withtrait@Eq.You can see the bad link here (Second sentence, "floating point types implement PartialEq but not Eq").