Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensures make tests run under /bin/dash (if available), like CI, and fixes a Makefile #81734

Merged
merged 4 commits into from
Feb 16, 2021

Commits on Feb 11, 2021

  1. Ensures make tests run under /bin/dash, like CI, and fixes a Makefile

    Updates `tools.mk` to explicitly require `SHELL := /bin/dash`, since CI
    uses `dash` but other environments (including developer local machines)
    may default to `bash`.
    
    Replaces bash-specific shell command in one Makefile with a
    dash-compatible alternative, and re-enables the affected Makefile test.
    
    Removes apparently redundant definition of `UNAME`.
    richkadel committed Feb 11, 2021
    Configuration menu
    Copy the full SHA
    01f5a2a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    625803d View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    b211acf View commit details
    Browse the repository at this point in the history

Commits on Feb 13, 2021

  1. Disabled SHELL=dash on Windows due to invalid path backslash handling

    Calling an executable via full path with Windows backslashes fails in
    dash.
    richkadel committed Feb 13, 2021
    Configuration menu
    Copy the full SHA
    cbe6c70 View commit details
    Browse the repository at this point in the history