Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: only copy python.exe to python3.exe if the latter does not exist #81762

Merged
merged 1 commit into from
Feb 4, 2021

Conversation

pietroalbini
Copy link
Member

We're copying the binary to make sure we can call python3.exe around, but it seems like the base image of GitHub Actions changed, copying the file before we do so. This PR changes the CI script to only copy the file if it doesn't already exist.

r? @m-ou-se
cc @Mark-Simulacrum

We're copying the binary to make sure we can call python3.exe around,
but it seems like the base image of GitHub Actions changed, copying the
file before we do so.

This commit changes the CI script to only copy the file if it doesn't
already exist.
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 4, 2021
@m-ou-se
Copy link
Member

m-ou-se commented Feb 4, 2021

@bors r+ p=1000

@bors
Copy link
Contributor

bors commented Feb 4, 2021

📌 Commit 575f694 has been approved by m-ou-se

@bors
Copy link
Contributor

bors commented Feb 4, 2021

🌲 The tree is currently closed for pull requests below priority 1000. This pull request will be tested once the tree is reopened.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 4, 2021
@bors
Copy link
Contributor

bors commented Feb 4, 2021

⌛ Testing commit 575f694 with merge 4f4656d...

@bors
Copy link
Contributor

bors commented Feb 4, 2021

☀️ Test successful - checks-actions
Approved by: m-ou-se
Pushing 4f4656d to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Feb 4, 2021
@bors bors merged commit 4f4656d into rust-lang:master Feb 4, 2021
@rustbot rustbot added this to the 1.51.0 milestone Feb 4, 2021
@m-ou-se
Copy link
Member

m-ou-se commented Feb 4, 2021

@bors treeclosed-

ehuss pushed a commit to ehuss/rust that referenced this pull request Feb 5, 2021
…u-se

CI: only copy python.exe to python3.exe if the latter does not exist

We're copying the binary to make sure we can call `python3.exe` around, but it seems like the base image of GitHub Actions changed, copying the file before we do so. This PR changes the CI script to only copy the file if it doesn't already exist.

r? `@m-ou-se`
cc `@Mark-Simulacrum`
@ehuss ehuss mentioned this pull request Feb 5, 2021
@ehuss ehuss added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Feb 5, 2021
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 6, 2021
[beta] backports

This backports:

* CI: only copy python.exe to python3.exe if the latter does not exist rust-lang#81762
* Make hitting the recursion limit in projection non-fatal rust-lang#81055
* Remove incorrect `delay_span_bug` rust-lang#81532
* introduce future-compatibility warning for forbidden lint groups rust-lang#81556
* Update cargo rust-lang#81755
* rustdoc: Fix visibility of trait and impl items rust-lang#81288
* Work around missing -dev packages in solaris docker image. rust-lang#81229
* Update LayoutError/LayoutErr stability attributes rust-lang#81767
* Revert 78373 ("dont leak return value after panic in drop") rust-lang#81257
* Rename `panic_fmt` lint to `non_fmt_panic` rust-lang#81729
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta-accepted Accepted for backporting to the compiler in the beta channel. merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants