Shorten html::render #82088
Merged
Shorten html::render #82088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @ollie27 (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Nicholas-Baron
force-pushed
the
shorten_html_render
branch
from
0862e34
to
206c443
Compare
jyn514
added
C-cleanup
jyn514
reviewed
Feb 16, 2021
Nicholas-Baron
force-pushed
the
shorten_html_render
branch
2 times, most recently
from
989fadb
to
5273ca8
Compare
This comment has been minimized.
This comment has been minimized.
Nicholas-Baron
force-pushed
the
shorten_html_render
branch
from
5273ca8
to
a899342
Compare
This comment has been minimized.
This comment has been minimized.
Nicholas-Baron
force-pushed
the
shorten_html_render
branch
from
a899342
to
c27b09a
Compare
This comment has been minimized.
This comment has been minimized.
|
@GuillaumeGomez this bitrots quickly, it would be nice to review it soon if possible. |
Nicholas-Baron
force-pushed
the
shorten_html_render
branch
from
c27b09a
to
aee0f7d
Compare
This comment has been minimized.
This comment has been minimized.
The warning is regarding a |
This comment has been minimized.
This comment has been minimized.
Nicholas-Baron
force-pushed
the
shorten_html_render
branch
from
aee0f7d
to
849c690
Compare
This comment has been minimized.
This comment has been minimized.
Nicholas-Baron
force-pushed
the
shorten_html_render
branch
from
849c690
to
5286284
Compare
This comment has been minimized.
This comment has been minimized.
Nicholas-Baron
force-pushed
the
shorten_html_render
branch
from
5286284
to
75ea154
Compare
This comment has been minimized.
This comment has been minimized.
bors
added
the
S-waiting-on-bors
|
☔ The latest upstream changes (presumably #82756) made this pull request unmergeable. Please resolve the merge conflicts. |
bors
added
S-waiting-on-author
|
@bors delegate=Nicholas-Baron This bitrots pretty quickly, so feel free to approve it yourself once you've fixed the conflict. Please use |
|
✌️ @Nicholas-Baron can now approve this pull request |
Due to a rebase, some edits were needed in the mod file.
Nicholas-Baron
force-pushed
the
shorten_html_render
branch
from
c34e695
to
afb8220
Compare
|
@bors: r=GuillaumeGomez |
|
📌 Commit afb8220 has been approved by |
bors
added
S-waiting-on-bors
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Mar 5, 2021
… r=GuillaumeGomez Shorten html::render The `mod.rs` for librustdoc's `html::render` was over 3,000 lines. This PR reduces it to around 2,300 by 1. Moving `Context` and associated `impl`s to a separate file 2. Moving the `print_item` function and its helpers to a separate file 3. Moving `write_shared` and `write_minify` to their own file Related to issue rust-lang#60302. Edit 1: `SharedContext` and related `impl`s is only 72 lines and so will not be moved.
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Mar 5, 2021
… r=GuillaumeGomez Shorten html::render The `mod.rs` for librustdoc's `html::render` was over 3,000 lines. This PR reduces it to around 2,300 by 1. Moving `Context` and associated `impl`s to a separate file 2. Moving the `print_item` function and its helpers to a separate file 3. Moving `write_shared` and `write_minify` to their own file Related to issue rust-lang#60302. Edit 1: `SharedContext` and related `impl`s is only 72 lines and so will not be moved.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 5, 2021
…laumeGomez Rollup of 5 pull requests Successful merges: - rust-lang#76716 (Don't warn for `missing_doc_examples` when item is #[doc(hidden)]) - rust-lang#82088 (Shorten html::render) - rust-lang#82690 (Update rustdoc documentation) - rust-lang#82752 (Add a regression test for issue-81712) - rust-lang#82765 (Fix polymorphization ICE on associated types in trait decls using const generics in bounds) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
m-ou-se
added a commit
to m-ou-se/rust
that referenced
this pull request
Mar 5, 2021
… r=GuillaumeGomez Shorten html::render The `mod.rs` for librustdoc's `html::render` was over 3,000 lines. This PR reduces it to around 2,300 by 1. Moving `Context` and associated `impl`s to a separate file 2. Moving the `print_item` function and its helpers to a separate file 3. Moving `write_shared` and `write_minify` to their own file Related to issue rust-lang#60302. Edit 1: `SharedContext` and related `impl`s is only 72 lines and so will not be moved.
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
mod.rsfor librustdoc'shtml::renderwas over 3,000 lines. This PR reduces it to around 2,300 byContextand associatedimpls to a separate fileprint_itemfunction and its helpers to a separate filewrite_sharedandwrite_minifyto their own fileRelated to issue #60302.
Edit 1:
SharedContextand relatedimpls is only 72 lines and so will not be moved.