Fix diagnostic suggests adding type `[type error]` #82720

henryboisdequin · 2021-03-03T11:22:13Z

Unresolved questions:

~~Why does this change output the diagnostic twice (src/test/ui/79040.rs)?~~ Thanks @oli-obk

Fixes rust-lang#79040 Unresolved questions: Why does this change output the diagnostic twice? Why does the CI fail when the errors are pointed out (UI tests)?

rust-highfive · 2021-03-03T11:22:16Z

r? @davidtwco

(rust-highfive has picked a reviewer for you, use r? to override)

src/test/ui/parser/item-free-static-no-body-semantic-fail.rs

oli-obk · 2021-03-03T13:48:51Z

Why does this change output the diagnostic twice (src/test/ui/79040.rs)?

It always did that, we just hide duplicates by default. The test suite wants to know about all diagnostics, so it doesn't do deduplication

henryboisdequin · 2021-03-03T14:52:13Z

@oli-obk I think this was the 1,419'th addition to src/test/ui hence why the tidy error 😮. What should I do to fix this?

src/test/ui/79040.rs

src/test/ui/typeck/issue-79040.stderr

oli-obk · 2021-03-03T17:25:49Z

Please run ./x.py test src/test/ui --bless and ./x.py test src/tools/tidy before pushing. These will allow you to quickly fix the problems locally instead of having to play ping-pong with CI

src/test/ui/parser/item-free-const-no-body-semantic-fail.rs

src/test/ui/parser/item-free-static-no-body-semantic-fail.rs

compiler/rustc_typeck/src/collect/type_of.rs

src/test/ui/typeck/typeck_type_placeholder_item.stderr

henryboisdequin · 2021-03-04T04:54:46Z

@rustbot label +S-waiting-on-author -S-waiting-on-review

…anewok Update tests names to start with `issue-` See `@JohnTitor's` [comment](rust-lang#82720 (comment)) `@rustbot` label +C-cleanup

…anewok Update tests names to start with `issue-` See ``@JohnTitor's`` [comment](rust-lang#82720 (comment)) ``@rustbot`` label +C-cleanup

henryboisdequin · 2021-03-06T02:55:28Z

@rustbot label -S-waiting-on-author +S-waiting-on-review

oli-obk · 2021-03-06T07:03:06Z

@bors r+ rollup

bors · 2021-03-06T07:03:07Z

📌 Commit 7d3a6f1 has been approved by oli-obk

Fix diagnostic suggests adding type `[type error]` Fixes rust-lang#79040 ### Unresolved questions: <del>Why does this change output the diagnostic twice (`src/test/ui/79040.rs`)?</del> Thanks `@oli-obk`

Fix diagnostic suggests adding type `[type error]` Fixes rust-lang#79040 ### Unresolved questions: <del>Why does this change output the diagnostic twice (`src/test/ui/79040.rs`)?</del> Thanks ``@oli-obk``

Fix diagnostic suggests adding type `[type error]` Fixes rust-lang#79040 ### Unresolved questions: <del>Why does this change output the diagnostic twice (`src/test/ui/79040.rs`)?</del> Thanks ```@oli-obk```

Fix diagnostic suggests adding type `[type error]` Fixes rust-lang#79040 ### Unresolved questions: <del>Why does this change output the diagnostic twice (`src/test/ui/79040.rs`)?</del> Thanks ````@oli-obk````

Rollup of 13 pull requests Successful merges: - rust-lang#77916 (Change built-in kernel targets to be os = none throughout) - rust-lang#82130 (Make some Option, Result methods unstably const) - rust-lang#82292 (Prevent specialized ZipImpl from calling `__iterator_get_unchecked` twice with the same index) - rust-lang#82402 (Remove RefCell around `module_trait_cache`) - rust-lang#82592 (Improve transmute docs with further clarifications) - rust-lang#82651 (Cleanup rustdoc warnings) - rust-lang#82720 (Fix diagnostic suggests adding type `[type error]`) - rust-lang#82751 (improve offset_from docs) - rust-lang#82793 (Move some tests to more suitable subdirs) - rust-lang#82803 (rustdoc: Add an unstable option to print all unversioned files) - rust-lang#82808 (Sync rustc_codegen_cranelift) - rust-lang#82822 (Fix typo) - rust-lang#82837 (tweak MaybeUninit docs) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup

Fix diagnostic suggests adding type [type error]

d9d6921

Fixes rust-lang#79040 Unresolved questions: Why does this change output the diagnostic twice? Why does the CI fail when the errors are pointed out (UI tests)?

rust-highfive assigned davidtwco Mar 3, 2021

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 3, 2021

This comment has been minimized.

Sign in to view

henryboisdequin mentioned this pull request Mar 3, 2021

Diagnostic suggests adding type [type error] #79040

Closed

This comment has been minimized.

Sign in to view

henryboisdequin force-pushed the fix-79040 branch from 2e7ce6a to f2afaf6 Compare March 3, 2021 11:53

This comment has been minimized.

Sign in to view

oli-obk reviewed Mar 3, 2021

View reviewed changes

src/test/ui/parser/item-free-static-no-body-semantic-fail.rs Show resolved Hide resolved

henryboisdequin force-pushed the fix-79040 branch from f2afaf6 to 6061033 Compare March 3, 2021 13:51

This comment has been minimized.

Sign in to view

JohnTitor reviewed Mar 3, 2021

View reviewed changes

src/test/ui/79040.rs Outdated Show resolved Hide resolved

henryboisdequin mentioned this pull request Mar 3, 2021

Tidy error: src/test/ui contains over 1418 files #82722

Closed

henryboisdequin force-pushed the fix-79040 branch from 6061033 to 80a0fc9 Compare March 3, 2021 15:09

JohnTitor reviewed Mar 3, 2021

View reviewed changes

src/test/ui/typeck/issue-79040.stderr Outdated Show resolved Hide resolved

This comment has been minimized.

Sign in to view

camelid reviewed Mar 3, 2021

View reviewed changes

src/test/ui/parser/item-free-const-no-body-semantic-fail.rs Show resolved Hide resolved

camelid reviewed Mar 3, 2021

View reviewed changes

src/test/ui/parser/item-free-static-no-body-semantic-fail.rs Show resolved Hide resolved

src/test/ui/parser/item-free-static-no-body-semantic-fail.rs Outdated Show resolved Hide resolved

estebank reviewed Mar 3, 2021

View reviewed changes

compiler/rustc_typeck/src/collect/type_of.rs Outdated Show resolved Hide resolved

henryboisdequin force-pushed the fix-79040 branch from 80a0fc9 to 66db82e Compare March 4, 2021 02:18

estebank reviewed Mar 4, 2021

View reviewed changes

compiler/rustc_typeck/src/collect/type_of.rs Outdated Show resolved Hide resolved

compiler/rustc_typeck/src/collect/type_of.rs Outdated Show resolved Hide resolved

This comment has been minimized.

Sign in to view

camelid reviewed Mar 4, 2021

View reviewed changes

src/test/ui/typeck/typeck_type_placeholder_item.stderr Outdated Show resolved Hide resolved

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 4, 2021

address comments

7d3a6f1

henryboisdequin force-pushed the fix-79040 branch from ee049f0 to 7d3a6f1 Compare March 6, 2021 02:51

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 6, 2021

henryboisdequin requested a review from oli-obk March 6, 2021 02:55

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 6, 2021

JohnTitor mentioned this pull request Mar 6, 2021

Rollup of 7 pull requests #82831

Closed

JohnTitor mentioned this pull request Mar 6, 2021

Rollup of 8 pull requests #82832

Closed

m-ou-se mentioned this pull request Mar 6, 2021

Rollup of 11 pull requests #82840

Closed

Dylan-DPC-zz mentioned this pull request Mar 6, 2021

Rollup of 10 pull requests #82847

Closed

JohnTitor mentioned this pull request Mar 7, 2021

Rollup of 13 pull requests #82851

Merged

bors merged commit a5a825e into rust-lang:master Mar 7, 2021

rustbot added this to the 1.52.0 milestone Mar 7, 2021

henryboisdequin deleted the fix-79040 branch March 7, 2021 05:51

dwrensha mentioned this pull request Apr 15, 2021

Internal Compiler Error: 'attempt to subtract with overflow', compiler/rustc_session/src/session.rs:478:22 #84219

Closed

camelid mentioned this pull request Oct 5, 2021

dtorck encountered internal error #89574

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix diagnostic suggests adding type `[type error]` #82720

Fix diagnostic suggests adding type `[type error]` #82720

henryboisdequin commented Mar 3, 2021 •

edited

Loading

rust-highfive commented Mar 3, 2021

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

oli-obk commented Mar 3, 2021

This comment has been minimized.

henryboisdequin commented Mar 3, 2021

This comment has been minimized.

oli-obk commented Mar 3, 2021

This comment has been minimized.

henryboisdequin commented Mar 4, 2021

henryboisdequin commented Mar 6, 2021

oli-obk commented Mar 6, 2021

bors commented Mar 6, 2021

Fix diagnostic suggests adding type [type error] #82720

Fix diagnostic suggests adding type [type error] #82720

Conversation

henryboisdequin commented Mar 3, 2021 • edited Loading

Unresolved questions:

rust-highfive commented Mar 3, 2021

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

oli-obk commented Mar 3, 2021

This comment has been minimized.

henryboisdequin commented Mar 3, 2021

This comment has been minimized.

oli-obk commented Mar 3, 2021

This comment has been minimized.

henryboisdequin commented Mar 4, 2021

henryboisdequin commented Mar 6, 2021

oli-obk commented Mar 6, 2021

bors commented Mar 6, 2021

Fix diagnostic suggests adding type `[type error]` #82720

Fix diagnostic suggests adding type `[type error]` #82720

henryboisdequin commented Mar 3, 2021 •

edited

Loading