Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Diagnostic cleanups #82935

Merged
merged 2 commits into from
Mar 12, 2021
Merged

Diagnostic cleanups #82935

merged 2 commits into from
Mar 12, 2021

Conversation

henryboisdequin
Copy link
Contributor

Follow up to #81503
Helps with #82916 (don't show note if span is DUMMY_SP)

@rust-highfive
Copy link
Collaborator

r? @matthewjasper

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 9, 2021
@henryboisdequin
Copy link
Contributor Author

@rustbot label +C-cleanup +A-diagnostics +T-compiler

@rustbot rustbot added A-diagnostics Area: Messages for errors, warnings, and lints C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 9, 2021
@jyn514
Copy link
Member

jyn514 commented Mar 10, 2021

r? @estebank

@estebank
Copy link
Contributor

r=me after addressing nitpick if you have the time.

@henryboisdequin
Copy link
Contributor Author

@estebank Done ✅

@jyn514
Copy link
Member

jyn514 commented Mar 12, 2021

@bors r=estebank

@bors
Copy link
Contributor

bors commented Mar 12, 2021

📌 Commit 26478c8 has been approved by estebank

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 12, 2021
@bors
Copy link
Contributor

bors commented Mar 12, 2021

⌛ Testing commit 26478c8 with merge 0cc64a3...

@bors
Copy link
Contributor

bors commented Mar 12, 2021

☀️ Test successful - checks-actions
Approved by: estebank
Pushing 0cc64a3 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Mar 12, 2021
@bors bors merged commit 0cc64a3 into rust-lang:master Mar 12, 2021
@rustbot rustbot added this to the 1.52.0 milestone Mar 12, 2021
@henryboisdequin henryboisdequin deleted the diagnostic-cleanups branch March 12, 2021 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@estebank estebank estebank left review comments

Assignees

@estebank estebank

Labels
A-diagnostics Area: Messages for errors, warnings, and lints C-cleanup Category: PRs that clean code up or issues documenting cleanup. merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.52.0
Development

Successfully merging this pull request may close these issues.
7 participants
@henryboisdequin @rust-highfive @jyn514 @estebank @bors @matthewjasper @rustbot