Reintroduce accidentally deleted assertions. #83018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These were removed in rust-lang#50198
|
r? @davidtwco (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
I would like to see a crater run on this, perhaps? Maybe there is some constant in the wild that we've let through despite our algorithms disagreeing on the exact bitpattern? |
|
This is very small and easily reverted. I think we should just merge it and see what the next beta crater says |
klensy
reviewed
Mar 11, 2021
|
@bors r=davidtwco |
|
📌 Commit c69b108 has been approved by |
bors
added
S-waiting-on-bors
|
@bors rollup |
|
I feel like if this is something we might expect breakage on, we probably should rollup? Even if it's really small. (Then we can bisect to this exact change?) |
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Mar 11, 2021
Reintroduce accidentally deleted assertions. These were removed in rust-lang#50198
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Mar 11, 2021
Reintroduce accidentally deleted assertions. These were removed in rust-lang#50198
This was referenced Mar 11, 2021
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 12, 2021
Rollup of 11 pull requests Successful merges: - rust-lang#80385 (Clarify what `Cell::replace` returns) - rust-lang#82571 (Rustdoc Json: Add tests for Reexports, and improve jsondocck) - rust-lang#82860 (Add `-Z unpretty` flag for the THIR) - rust-lang#82950 (convert slice doc link to intra-doc links) - rust-lang#82965 (Add spirv extension handling in compiletest) - rust-lang#82966 (update MSYS2 link in README) - rust-lang#82979 (Fix "run" button position in error index) - rust-lang#83001 (Ignore Vim swap files) - rust-lang#83003 (rustdoc: tweak the search index format) - rust-lang#83013 (Adjust some `#[cfg]`s to take non-Unix non-Windows operating systems into account) - rust-lang#83018 (Reintroduce accidentally deleted assertions.) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were removed in #50198