Enable -W semicolon_in_expressions_from_macros in bootstrap
#83089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
|
r=me in theory but looks like there's at least one use left |
Aaron1011
added a commit
to Aaron1011/stdarch
that referenced
this pull request
Mar 13, 2021
Amanieu
pushed a commit
to rust-lang/stdarch
that referenced
this pull request
Mar 13, 2021
Aaron1011
added
S-blocked
|
This is now blocked on bumping the |
|
@Aaron1011 this should be possible since #83776 |
This comment has been minimized.
This comment has been minimized.
|
It looks like rust-lang/stdarch#1080 wasn't included in the submodule bump. |
This comment has been minimized.
This comment has been minimized.
Now that stdarch has been updated, we can do this without breaking the build.
Aaron1011
added
S-waiting-on-review
|
@Mark-Simulacrum This is now ready to merge |
|
@bors r+ |
|
📌 Commit 020d83d has been approved by |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that stdarch has been updated, we can do this without breaking the
build.