Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add OR_PATTERNS_BACK_COMPAT lint #83468

Merged
merged 2 commits into from
Apr 2, 2021
Merged

add OR_PATTERNS_BACK_COMPAT lint #83468

merged 2 commits into from
Apr 2, 2021

Conversation

Rustin170506
Copy link
Member

close #83318

@rust-highfive
Copy link
Collaborator

r? @petrochenkov

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 25, 2021
@Rustin170506
Copy link
Member Author

Rustin170506 commented Mar 25, 2021 •
edited
Loading

/hold

  • Need to add comments
  • Need to add tests

@Rustin170506 Rustin170506 mentioned this pull request Mar 25, 2021
Closed
@Rustin170506
Copy link
Member Author

r? @nikomatsakis

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
nikomatsakis
nikomatsakis requested changes Mar 26, 2021
View reviewed changes
Copy link
Contributor

@nikomatsakis nikomatsakis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks basically right! We do need tests though.

compiler/rustc_expand/src/mbe/macro_rules.rs Outdated Show resolved Hide resolved
compiler/rustc_expand/src/mbe/macro_rules.rs Show resolved Hide resolved
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@Rustin170506 Rustin170506 marked this pull request as ready for review March 27, 2021 07:44
@Rustin170506 Rustin170506 force-pushed the rustin-patch-lint branch 2 times, most recently from e190c29 to be47980 Compare March 27, 2021 07:54
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@Rustin170506 Rustin170506 force-pushed the rustin-patch-lint branch 2 times, most recently from cc93aff to f22af2c Compare March 27, 2021 11:05
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@Rustin170506 Rustin170506 marked this pull request as draft March 30, 2021 02:08
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors bors added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Apr 1, 2021
@nikomatsakis
Copy link
Contributor

@mark-i-m d'oh!

@nikomatsakis
Copy link
Contributor

@hi-rustin can you bless the test please?

nikomatsakis
nikomatsakis requested changes Apr 1, 2021
View reviewed changes
src/test/ui/macros/macro-or-patterns-back-compat.fixed Outdated Show resolved Hide resolved
src/test/ui/macros/macro-or-patterns-back-compat.fixed Outdated Show resolved Hide resolved
src/test/ui/macros/macro-or-patterns-back-compat.fixed Outdated Show resolved Hide resolved
src/test/ui/macros/macro-or-patterns-back-compat.fixed Outdated Show resolved Hide resolved
src/test/ui/macros/macro-or-patterns-back-compat.rs Outdated Show resolved Hide resolved
src/test/ui/macros/macro-or-patterns-back-compat.rs Outdated Show resolved Hide resolved
src/test/ui/macros/macro-or-patterns-back-compat.stderr Outdated Show resolved Hide resolved
src/test/ui/macros/macro-or-patterns-back-compat.stderr Outdated Show resolved Hide resolved
src/test/ui/macros/macro-or-patterns-back-compat.stderr Outdated Show resolved Hide resolved
src/test/ui/macros/macro-or-patterns-back-compat.stderr Outdated Show resolved Hide resolved
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@Rustin170506
Copy link
Member Author

@rustbot modify labels: +S-waiting-on-review -S-waiting-on-author

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 2, 2021
@nikomatsakis
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented Apr 2, 2021

📌 Commit aa987c2 has been approved by nikomatsakis

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 2, 2021
@bors
Copy link
Contributor

bors commented Apr 2, 2021

⌛ Testing commit aa987c2 with merge 36bcf40...

@bors
Copy link
Contributor

bors commented Apr 2, 2021

☀️ Test successful - checks-actions
Approved by: nikomatsakis
Pushing 36bcf40 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 2, 2021
@bors bors merged commit 36bcf40 into rust-lang:master Apr 2, 2021
@rustbot rustbot added this to the 1.53.0 milestone Apr 2, 2021
This was referenced Apr 2, 2021
Closed
Merged
@Rustin170506 Rustin170506 deleted the rustin-patch-lint branch April 3, 2021 02:18
@nikomatsakis nikomatsakis mentioned this pull request Apr 12, 2021
Closed
@ehuss ehuss mentioned this pull request Apr 22, 2021
Closed
@m-ou-se m-ou-se mentioned this pull request Sep 3, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mark-i-m mark-i-m mark-i-m left review comments

@nikomatsakis nikomatsakis nikomatsakis approved these changes

Assignees

@nikomatsakis nikomatsakis

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.53.0
Development

Successfully merging this pull request may close these issues.

Migration for or patterns
8 participants
@Rustin170506 @rust-highfive @rust-log-analyzer @mark-i-m @nikomatsakis @bors @petrochenkov @rustbot