Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add bad_asm_style to HardwiredLints #84068

Merged
merged 2 commits into from
Apr 12, 2021
Merged

Add bad_asm_style to HardwiredLints #84068

merged 2 commits into from
Apr 12, 2021

Conversation

Amanieu
Copy link
Member

@Amanieu Amanieu commented Apr 10, 2021

This was missed when the lint was added, which prevents the lint from being ignored with #[allow].

@rust-highfive
Copy link
Collaborator

r? @lcnr

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 10, 2021
@jyn514
Copy link
Member

jyn514 commented Apr 10, 2021

This was missed when the lint was added, which prevents the lint from being ignored with #[allow].

Could you add a test for that?

@jyn514 jyn514 added A-lint Area: Lints (warnings about flaws in source code) such as unused_mut. F-asm `#![feature(asm)]` (not `llvm_asm`) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 10, 2021
@Amanieu Amanieu mentioned this pull request Apr 11, 2021
Merged
@lcnr
Copy link
Contributor

lcnr commented Apr 12, 2021

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Apr 12, 2021

📌 Commit 83c2c5b has been approved by lcnr

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 12, 2021
@bors
Copy link
Contributor

bors commented Apr 12, 2021

⌛ Testing commit 83c2c5b with merge c18c0ad...

@bors
Copy link
Contributor

bors commented Apr 12, 2021

☀️ Test successful - checks-actions
Approved by: lcnr
Pushing c18c0ad to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 12, 2021
@bors bors merged commit c18c0ad into rust-lang:master Apr 12, 2021
@rustbot rustbot added this to the 1.53.0 milestone Apr 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@lcnr lcnr

Labels
A-lint Area: Lints (warnings about flaws in source code) such as unused_mut. F-asm `#![feature(asm)]` (not `llvm_asm`) merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.53.0
Development

Successfully merging this pull request may close these issues.
6 participants
@Amanieu @rust-highfive @jyn514 @lcnr @bors @rustbot