-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update RLS and rustfmt #84103
update RLS and rustfmt #84103
Conversation
Some changes occurred in src/tools/rustfmt. |
(rust-highfive has picked a reviewer for you, use r? to override) |
|
@bors delegate+ r=me |
✌️ @calebcartwright can now approve this pull request |
@Xanewok - I think RLS would need rust-lang/rls#1725 in order to address the build issue, would it be possible to get that merged, and/or is there a different branch/tag/etc. in RLS I should update the submod to instead?
|
This comment has been minimized.
This comment has been minimized.
@calebcartwright rust-lang/rls#1725 is now merged, could you try using latest RLS master? |
506fa38
to
9db7e84
Compare
This comment has been minimized.
This comment has been minimized.
You'll need to update the patch list here to include |
9db7e84
to
e2fe4f2
Compare
Yup had just found that a little while ago as well 👍 |
@bors r+ p=1 |
📌 Commit e2fe4f2 has been approved by |
☀️ Test successful - checks-actions |
📣 Toolstate changed by #84103! Tested on commit 1284da3. 🎉 rls on windows: build-fail → test-pass (cc @Xanewok). |
Tested on commit rust-lang/rust@1284da3. Direct link to PR: <rust-lang/rust#84103> 🎉 rls on windows: build-fail → test-pass (cc @Xanewok). 🎉 rls on linux: build-fail → test-pass (cc @Xanewok). 🎉 rustfmt on windows: build-fail → test-pass (cc @calebcartwright @topecongiro). 🎉 rustfmt on linux: build-fail → test-pass (cc @calebcartwright @topecongiro).
Fixes #83460 and fixes #83459
cc @Xanewok