Deprecate the core::raw / std::raw module #84207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It only contains the `TraitObject` struct which exposes components of wide pointer. Pointer metadata APIs are designed to replace this: rust-lang#81513
|
r? @dtolnay (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
CC @rust-lang/libs, although this already went through FCP as part of rust-lang/rfcs#2580 |
This comment has been minimized.
This comment has been minimized.
dtolnay
approved these changes
Apr 15, 2021
dtolnay
requested changes
Apr 15, 2021
library/std/src/lib.rs
Outdated
| @@ -456,6 +456,7 @@ pub use core::pin; | |||
| #[stable(feature = "rust1", since = "1.0.0")] | |||
| pub use core::ptr; | |||
| #[stable(feature = "rust1", since = "1.0.0")] | |||
| #[allow(deprecated_in_future)] | |||
There was a problem hiding this comment.
I think it wants this to be:
Suggested change
| #[allow(deprecated_in_future)] | |
| #[allow(deprecated)] |
given that 1.53.0 is already the present as far as nightly is concerned. Otherwise it's currently failing with:
error: use of deprecated module `core::raw`: use pointer metadata APIs instead https://github.com/rust-lang/rust/issues/81513
--> library/std/src/lib.rs:460:9
|
460 | pub use core::raw;
| ^^^^^^^^^
|
= note: `-D deprecated` implied by `-D warnings`There was a problem hiding this comment.
It looks like stage0 (compiling from beta) emits deprecated_in_future and stage1+ emits deprecated
This comment has been minimized.
This comment has been minimized.
dtolnay
requested changes
Apr 15, 2021
library/std/src/lib.rs
Outdated
| @@ -456,6 +456,7 @@ pub use core::pin; | |||
| #[stable(feature = "rust1", since = "1.0.0")] | |||
| pub use core::ptr; | |||
| #[stable(feature = "rust1", since = "1.0.0")] | |||
| #[allow(deprecated)] | |||
There was a problem hiding this comment.
Suggested change
| #[allow(deprecated)] | |
| #[allow(deprecated, deprecated_in_future)] |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
SimonSapin
force-pushed
the
deprecate-core-raw
branch
from
c234484
to
4d683c0
Compare
dtolnay
approved these changes
Apr 17, 2021
|
@bors r+ |
|
📌 Commit 4d683c0 has been approved by |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 4, 2021
…apin Remove the deprecated `core::raw` and `std::raw` module. A few months has passed since rust-lang#84207. I think now it's time for the final removal. Closes rust-lang#27751. r? `@m-ou-se`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It only contains the
TraitObjectstruct which exposes components of wide pointer. Pointer metadata APIs are designed to replace this: #81513