Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark evaluate_obligation query as eval_always #84280

Closed
wants to merge 1 commit into from
Closed

Mark evaluate_obligation query as eval_always #84280

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions compiler/rustc_middle/src/query/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1514,6 +1514,11 @@ rustc_queries! {
query evaluate_obligation(
goal: CanonicalPredicateGoal<'tcx>
) -> Result<traits::EvaluationResult, traits::OverflowError> {
// FIXME(#83538): This queery shouldm't be influenced by any untracked
// blobal state, but it currently is. We use `eval_aways` to prevent this
// from causing ICEs - when the underlying issue is fixed, the `eval_always`
// modifier should be removed.
Comment on lines +1517 to +1520
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment full of typos :-(

eval_always
desc { "evaluating trait selection obligation `{}`", goal.value.value }
}

Expand Down