Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix x.py test --stage 0 src/tools/miri #84775

Closed
wants to merge 1 commit into from

Conversation

jyn514
Copy link
Member

@jyn514 jyn514 commented May 1, 2021

Previously, it would give an error that libLLVM.so couldn't be found.

Helps with #78778. That seems to be tracking two separate issues; the original issue from the error-index is something different (cc #84471).

r? @Mark-Simulacrum cc @RalfJung

Previously, it would give an error that libLLVM.so couldn't be found.
@jyn514 jyn514 added T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) A-miri Area: The miri tool A-contributor-roadblock Area: Makes things more difficult for new contributors to rust itself labels May 1, 2021
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 1, 2021
@RalfJung
Copy link
Member

RalfJung commented May 1, 2021

I thought I tried that and it didn't work...

What does "helps with" mean, does testing Miri in stage 0 work after this?

@RalfJung
Copy link
Member

RalfJung commented May 1, 2021

With this patch (and after adding back the missing or_pattern feature gate for a bootstrap build), I still get

     Running `build/x86_64-unknown-linux-gnu/stage0-tools/x86_64-unknown-linux-gnu/release/cargo-miri miri setup`
thread 'main' panicked at 'failed to determine underlying rustc version of Miri: CommandError { stdout: "", stderr: "/home/r/src/rust/rustc.2/build/x86_64-unknown-linux-gnu/stage0-tools-bin/miri: error while loading shared libraries: libLLVM-12-rust-1.54.0-nightly.so: cannot open shared object file: No such file or directory\n" }', src/tools/miri/cargo-miri/bin.rs:190:38
stack backtrace:
   0: rust_begin_unwind
             at ./library/std/src/panicking.rs:493:5
   1: core::panicking::panic_fmt
             at ./library/core/src/panicking.rs:92:14
   2: core::result::unwrap_failed
             at ./library/core/src/result.rs:1355:5
   3: core::result::Result<T,E>::expect
             at ./library/core/src/result.rs:997:23
   4: cargo_miri::version_info
             at ./src/tools/miri/cargo-miri/bin.rs:190:5
   5: cargo_miri::setup
             at ./src/tools/miri/cargo-miri/bin.rs:399:16
   6: cargo_miri::phase_cargo_miri
             at ./src/tools/miri/cargo-miri/bin.rs:477:5
   7: cargo_miri::main
             at ./src/tools/miri/cargo-miri/bin.rs:965:25
   8: core::ops::function::FnOnce::call_once
             at ./library/core/src/ops/function.rs:227:5
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.


command did not execute successfully: "/home/r/src/rust/rustc.2/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "run" "--target" "x86_64-unknown-linux-gnu" "-Zbinary-dep-depinfo" "-j" "8" "--release" "--manifest-path" "/home/r/src/rust/rustc.2/src/tools/miri/cargo-miri/Cargo.toml" "--" "miri" "setup"
expected success, got: exit code: 101

So I don't think this actually helps?

@jyn514
Copy link
Member Author

jyn514 commented May 1, 2021

Hmm, I think x.py caches setup. I must have made some other change that fixed this - maybe it was #84776?

@jyn514 jyn514 closed this May 1, 2021
@RalfJung
Copy link
Member

RalfJung commented May 1, 2021

Miri caches setup. Do rm ~/.cache/miri -rf (or whatever the application cache folder is on macOS/Windows) to reset this.

@jyn514 jyn514 deleted the miri-sysroot branch May 1, 2021 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-contributor-roadblock Area: Makes things more difficult for new contributors to rust itself A-miri Area: The miri tool S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants