Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable] 1.52.1 release #85097

Merged
merged 4 commits into from
May 9, 2021
Merged

[stable] 1.52.1 release #85097

merged 4 commits into from
May 9, 2021

Conversation

Mark-Simulacrum
Copy link
Member

Note that this may not be the version we end up going with. However, in the interests of having the artifacts available should we choose to use them, this PR will prepare a set of artifacts which:

  • Disables incremental compilation unless the user has explicitly opted in (via an environment variable, for ease of setting it globally)
  • Adds the improved error message which tells the user how to workaround the breakage, intended for users who do explicitly re-enable incremental

Note that the release notes mark Monday as the release date; I think it is likely that if we choose to go down this path we should indeed release on Monday, and potentially follow up in a week or two (e.g., May 20th) with a 1.52.2 if we have confidence in some collection of fixes. I think this will be unlikely, though.

Please also note that this PR breaks normal policy by landing commits/work only on the stable branch. It is my intent to follow up with PRs toward beta and master, as well, but in the interests of making sure we have artifacts as early as possible I am posting this first. It will also let us provide an ask for testing, via the dev-static bucket, sooner rather than later.

@rust-highfive
Copy link
Collaborator

@Mark-Simulacrum: no appropriate reviewer found, use r? to override

@rust-highfive
Copy link
Collaborator

⚠️ Warning ⚠️

  • Pull requests are usually filed against the master branch for this repo, but this one is against stable. Please double check that you specified the right target!

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 9, 2021
@Mark-Simulacrum Mark-Simulacrum self-assigned this May 9, 2021
@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

Mark-Simulacrum and others added 4 commits May 8, 2021 22:05
This disables incremental (i.e., -Cincremental) taking effect unless an
environment variable, RUSTC_FORCE_INCREMENTAL, is set to 1 in the environment of
the running rustc. Currently incremental causes errors for many users, and we do
not have an expectation of being able to quickly fix these errors in a
backportable way - so, for now, disable incremental entirely. The user can still
opt-in, but this way the majority of users merely get slower builds, not broken
builds.
This bumps the stable version number and adds corresponding release notes.
@Mark-Simulacrum
Copy link
Member Author

@bors r+ rollup=never p=100

@bors
Copy link
Contributor

bors commented May 9, 2021

📌 Commit a0190b5 has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 9, 2021
@bors
Copy link
Contributor

bors commented May 9, 2021

⌛ Testing commit a0190b5 with merge 9bc8c42...

Rust users **should** upgrade to 1.52.0 or 1.52.1: the bugs that are detected by
newly added incremental verification are still present in past stable versions,
and are not yet fixed on any channel. These bugs can lead to miscompilation of
Rust binaries.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: I think it would be good to scope this sentence more tightly by moving the mention of incr comp from the next sentence up into this one. Ie: "Rust binaries when incremental compilation is enabled"

@bors
Copy link
Contributor

bors commented May 9, 2021

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing 9bc8c42 to stable...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label May 9, 2021
@bors bors merged commit 9bc8c42 into rust-lang:stable May 9, 2021
@rustbot rustbot added this to the 1.52.1 milestone May 9, 2021
@Mark-Simulacrum Mark-Simulacrum deleted the stable-next branch May 9, 2021 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants