Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove const_fn feature gate #85109

Merged
merged 3 commits into from
May 11, 2021
Merged

remove const_fn feature gate #85109

merged 3 commits into from
May 11, 2021

Conversation

RalfJung
Copy link
Member

@RalfJung RalfJung commented May 9, 2021

Fixes #84510
r? @oli-obk

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 9, 2021
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@oli-obk
Copy link
Contributor

oli-obk commented May 9, 2021

@bors r+

@bors
Copy link
Contributor

bors commented May 9, 2021

📌 Commit bafc51e has been approved by oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 9, 2021
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request May 9, 2021
@Dylan-DPC
Rollup merge of rust-lang#85109 - RalfJung:remove-const_fn, r=oli-obk
46f6c38 
remove const_fn feature gate

Fixes rust-lang#84510
r? `@oli-obk`
@Dylan-DPC-zz Dylan-DPC-zz mentioned this pull request May 9, 2021
Closed
@Dylan-DPC-zz
Copy link

Dylan-DPC-zz commented May 9, 2021 •
edited
Loading

failed in rollup

@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 9, 2021
@RalfJung
Copy link
Member Author

RalfJung commented May 9, 2021

@bors rollup=never

@RalfJung RalfJung mentioned this pull request May 9, 2021
Merged
@RalfJung
Copy link
Member Author

@bors r=oli-obk

@bors
Copy link
Contributor

bors commented May 10, 2021

📌 Commit 1f17fc2 has been approved by oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 10, 2021
@bors
Copy link
Contributor

bors commented May 10, 2021

⌛ Testing commit 1f17fc2 with merge 6d59681427c0886026637d8a5bfcb539dcbbabfe...

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors
Copy link
Contributor

bors commented May 10, 2021

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 10, 2021
@RalfJung
Copy link
Member Author

I blessed the test by hand now.^^ Let's see if that worked.

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@flip1995
Copy link
Member

It says "completed successfully" but it also says

Normally deleting build/<target>/stage-0-tools/deps and then rebuilding it helps.

I always compile Clippy on stage 1, since I always get weird failures on stage 0.

You're hand-blessing increased the line numbers by 1 instead of decreasing it by one.

@RalfJung
Copy link
Member Author

Normally deleting build//stage-0-tools/deps and then rebuilding it helps.

You mean stage0-tools, I assume. That did not help though:

/home/r/src/rust/rustc.2/build/x86_64-unknown-linux-gnu/stage0-tools-bin/clippy-driver: error while loading shared libraries: libLLVM-12-rust-1.54.0-nightly.so: cannot open shared object file: No such file or directory

Cc #78778

You're hand-blessing increased the line numbers by 1 instead of decreasing it by one.

Ah oops

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@RalfJung
Copy link
Member Author

FWIW, even with --stage 1, --bless and --test-args do not seem to work properly...

But tests pass locally now. :)

@RalfJung
Copy link
Member Author

@bors r=oli-obk

@bors
Copy link
Contributor

bors commented May 11, 2021

📌 Commit 74918b7 has been approved by oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 11, 2021
@bors
Copy link
Contributor

bors commented May 11, 2021

⌛ Testing commit 74918b7 with merge 506e75c...

@bors
Copy link
Contributor

bors commented May 11, 2021

☀️ Test successful - checks-actions
Approved by: oli-obk
Pushing 506e75c to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label May 11, 2021
@bors bors merged commit 506e75c into rust-lang:master May 11, 2021
@rustbot rustbot added this to the 1.54.0 milestone May 11, 2021
@rust-highfive rust-highfive mentioned this pull request May 11, 2021
Closed
@rust-highfive
Copy link
Collaborator

📣 Toolstate changed by #85109!

Tested on commit 506e75c.
Direct link to PR: #85109

💔 miri on windows: test-pass → test-fail (cc @RalfJung @oli-obk @eddyb).
💔 miri on linux: test-pass → test-fail (cc @RalfJung @oli-obk @eddyb).

rust-highfive added a commit to rust-lang-nursery/rust-toolstate that referenced this pull request May 11, 2021
@rust-highfive
📣 Toolstate changed by rust-lang/rust#85109!
a1c3c01 
Tested on commit rust-lang/rust@506e75c.
Direct link to PR: <rust-lang/rust#85109>

💔 miri on windows: test-pass → test-fail (cc @RalfJung @oli-obk @eddyb).
💔 miri on linux: test-pass → test-fail (cc @RalfJung @oli-obk @eddyb).
This was referenced May 11, 2021
Merged
Merged
@RalfJung RalfJung deleted the remove-const_fn branch May 11, 2021 17:48
@JohnTitor JohnTitor mentioned this pull request May 12, 2021
Merged
@HybridEidolon HybridEidolon mentioned this pull request May 14, 2021
Merged
flip1995 pushed a commit to flip1995/rust that referenced this pull request May 20, 2021
@bors
Auto merge of rust-lang#85109 - RalfJung:remove-const_fn, r=oli-obk
918a1a2 
remove const_fn feature gate

Fixes rust-lang#84510
r? `@oli-obk`
@RalfJung RalfJung mentioned this pull request Jun 2, 2021
Open
4 tasks
@programmerjake programmerjake mentioned this pull request Mar 21, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oli-obk oli-obk oli-obk left review comments

Assignees

@oli-obk oli-obk

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.54.0
Development

Successfully merging this pull request may close these issues.

Get rid of "const_fn" feature gate
8 participants
@RalfJung @rust-log-analyzer @oli-obk @bors @Dylan-DPC-zz @flip1995 @rust-highfive @rustbot