Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce amount of function pointers in query invocation. #85154

Merged
merged 2 commits into from
Jun 15, 2021

Conversation

cjgillot
Copy link
Contributor

r? @ghost

@cjgillot
Copy link
Contributor Author

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label May 10, 2021
@bors
Copy link
Contributor

bors commented May 10, 2021

⌛ Trying commit 54812b2fc5138b294a94bcef06a0862dd702c587 with merge c2b73ae0efbe925df17fdc16e66fa801d11da357...

@bors
Copy link
Contributor

bors commented May 10, 2021

☀️ Try build successful - checks-actions
Build commit: c2b73ae0efbe925df17fdc16e66fa801d11da357 (c2b73ae0efbe925df17fdc16e66fa801d11da357)

@rust-timer
Copy link
Collaborator

Queued c2b73ae0efbe925df17fdc16e66fa801d11da357 with parent 544d124, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking try commit (c2b73ae0efbe925df17fdc16e66fa801d11da357): comparison url.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying rollup- to bors.

Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels May 10, 2021
@bjorn3
Copy link
Member

bjorn3 commented May 14, 2021

Mostly improvements up to 0.5%, but also a couple of regressions up to 1.6%.

@cjgillot
Copy link
Contributor Author

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label May 15, 2021
@bors
Copy link
Contributor

bors commented May 15, 2021

⌛ Trying commit 28ebdc070e4f5a3f300bc6893f463917bb1296f2 with merge 19f38705d2fff4b15315f9aea07919014862c418...

@bors
Copy link
Contributor

bors commented May 15, 2021

☀️ Try build successful - checks-actions
Build commit: 19f38705d2fff4b15315f9aea07919014862c418 (19f38705d2fff4b15315f9aea07919014862c418)

@rust-timer
Copy link
Collaborator

Queued 19f38705d2fff4b15315f9aea07919014862c418 with parent 428636f, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking try commit (19f38705d2fff4b15315f9aea07919014862c418): comparison url.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying rollup- to bors.

Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label May 15, 2021
Copy link
Member

@bjorn3 bjorn3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall improvements up to 0.6% with only a few small regressions up to 0.3%. No impact on bootstrap time.

compiler/rustc_query_impl/src/plumbing.rs Outdated Show resolved Hide resolved
compiler/rustc_query_impl/src/keys.rs Outdated Show resolved Hide resolved
@rust-log-analyzer

This comment has been minimized.

@bors
Copy link
Contributor

bors commented May 30, 2021

☔ The latest upstream changes (presumably #85319) made this pull request unmergeable. Please resolve the merge conflicts.

@JohnCSimon JohnCSimon removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 14, 2021
@JohnCSimon JohnCSimon added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 14, 2021
@JohnTitor
Copy link
Member

Looks like it's ready to review?

@cjgillot
Copy link
Contributor Author

Nobody is assigned yet.
r? @bjorn3 (please reassign if you can't)

@bjorn3
Copy link
Member

bjorn3 commented Jun 15, 2021

@bors r+

@bors
Copy link
Contributor

bors commented Jun 15, 2021

📌 Commit 8ed82eb has been approved by bjorn3

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 15, 2021
@bors
Copy link
Contributor

bors commented Jun 15, 2021

⌛ Testing commit 8ed82eb with merge 12d0849...

@bors
Copy link
Contributor

bors commented Jun 15, 2021

☀️ Test successful - checks-actions
Approved by: bjorn3
Pushing 12d0849 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jun 15, 2021
@bors bors merged commit 12d0849 into rust-lang:master Jun 15, 2021
@rustbot rustbot added this to the 1.55.0 milestone Jun 15, 2021
@cjgillot cjgillot deleted the lessfn branch June 17, 2021 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants