Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ipv6Addr::is_unicast #85791

Merged
merged 2 commits into from
Jun 9, 2021
Merged

Add Ipv6Addr::is_unicast #85791

merged 2 commits into from
Jun 9, 2021

Conversation

CDirkx
Copy link
Contributor

@CDirkx CDirkx commented May 28, 2021

Adds an unstable utility method Ipv6Addr::is_unicast under the feature flag ip (tracking issue: #27709).

Added for completeness with the other unicast methods (see also #85604 (comment)) and opposite of is_multicast.

@rust-highfive
Copy link
Collaborator

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 28, 2021
@CDirkx CDirkx changed the title Is unicast Add Ipv6Addr::is_unicast May 28, 2021
@Mark-Simulacrum
Copy link
Member

r? @joshtriplett

@joshtriplett joshtriplett added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label May 31, 2021
@joshtriplett
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented May 31, 2021

📌 Commit 5de77b3e77e1601fd986723c2a48b60089978195 has been approved by joshtriplett

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 31, 2021
@CDirkx
Copy link
Contributor Author

CDirkx commented May 31, 2021

Resolved the merge conflict

@JohnTitor
Copy link
Member

@bors r=joshtriplett

@bors
Copy link
Contributor

bors commented Jun 9, 2021

📌 Commit 187b415 has been approved by joshtriplett

bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 9, 2021
Rollup of 11 pull requests

Successful merges:

 - rust-lang#85676 (Fix documentation style inconsistencies for IP addresses)
 - rust-lang#85715 (Document `From` impls in string.rs)
 - rust-lang#85791 (Add `Ipv6Addr::is_unicast`)
 - rust-lang#85957 (Display defaults on const params- rustdoc )
 - rust-lang#85982 (Enable rustdoc to document safe wasm intrinsics)
 - rust-lang#86121 (Forwarding implementation for Seek trait's stream_position method)
 - rust-lang#86124 (Include macro name in 'local ambiguity' error)
 - rust-lang#86128 (Refactor: Extract render_summary from render_impl.)
 - rust-lang#86142 (Simplify proc_macro code using Bound::cloned().)
 - rust-lang#86158 (Update books)
 - rust-lang#86159 (Update cargo)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 3bc8221 into rust-lang:master Jun 9, 2021
@rustbot rustbot added this to the 1.54.0 milestone Jun 9, 2021
@CDirkx CDirkx deleted the is_unicast branch June 9, 2021 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants