Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove methods under Implementors on trait pages #85970

Merged
merged 8 commits into from
Jun 17, 2021
Merged

Remove methods under Implementors on trait pages #85970

merged 8 commits into from
Jun 17, 2021

Commits on Jun 17, 2021

  1. Remove methods under Implementors on trait pages 

    These were hidden by default, and duplicated information already on the
page anyhow.

Also remove the "Auto-hide trait implementors of a trait" setting,
which is not needed anymore.
    @jsha
    jsha committed Jun 17, 2021
    Configuration menu
    Copy the full SHA
    ce64729 View commit details
    Browse the repository at this point in the history

  2. Use render_impl_summary when rendering traits.

    @jsha
    jsha committed Jun 17, 2021
    Configuration menu
    Copy the full SHA
    bff4f07 View commit details
    Browse the repository at this point in the history

  3. Add doc(hidden) to all __iterator_get_unchecked 

    This method on the Iterator trait is doc(hidden), and about half of
implementations were doc(hidden). This adds the attribute to the
remaining implementations.
    @jsha
    jsha committed Jun 17, 2021
    Configuration menu
    Copy the full SHA
    910c7fa View commit details
    Browse the repository at this point in the history

  4. Make portability part of the summary. 

    That means it will be visible under "Implementors" on trait pages, and
under "Implementations" on struct/enum pages, even when all methods are
collapsed.

Switch to a float layout for rightside elements.
    @jsha
    jsha committed Jun 17, 2021
    Configuration menu
    Copy the full SHA
    593d6d1 View commit details
    Browse the repository at this point in the history

  5. Factor out render_rightside 

    This covers rendering of stability_since and the srclink across methods
and trait implementations, so their DOM representation is consistent.
    @jsha
    jsha committed Jun 17, 2021
    Configuration menu
    Copy the full SHA
    5de1391 View commit details
    Browse the repository at this point in the history

  6. Move anchor earlier in the DOM for easier layout

    @jsha
    jsha committed Jun 17, 2021
    Configuration menu
    Copy the full SHA
    c4fa6d5 View commit details
    Browse the repository at this point in the history

  7. Fix target highlighting in rustdoc. 

    Also factor out outer_version and const_outer_version into
render_rightside.
    @jsha
    jsha committed Jun 17, 2021
    Configuration menu
    Copy the full SHA
    2ac5c17 View commit details
    Browse the repository at this point in the history

  8. Restore details for Impls on Foreign Types 

    These were previously removed along with the details in the
"Implementors" section of trait pages. But for "Implementations on
Foreign Types," we need to include the details because they will not be
documented anywhere else.
    @jsha
    jsha committed Jun 17, 2021
    Configuration menu
    Copy the full SHA
    bf81e13 View commit details
    Browse the repository at this point in the history