-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not suggest to add type annotations for unnameable types #86215
Conversation
r? @jackh726 (rust-highfive has picked a reviewer for you, use r? to override) |
92a2c48
to
a2f547e
Compare
a2f547e
to
f687d5c
Compare
@bors delegate+ r=me with or without @fee1-dead's suggestion on suggesting a fn ptr instead of a fn def (I'd like to see it here, but also okay with that as a followup) |
✌️ @FabianWolff can now approve this pull request |
5e72a30
to
79dc9a7
Compare
@bors r+ |
📌 Commit 79dc9a7 has been approved by |
☀️ Test successful - checks-actions |
Consider this example:
This currently produces the following output:
However, these suggestions are obviously useless, because the suggested types cannot be written down. With my changes, the suggestion is replaced with a note, because there is no simple fix: