Add regression test for issue #37508 #86352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
JohnTitor
reviewed
Jun 16, 2021
|
@JohnTitor Thanks for taking a look. Any suggestions on how to approach this? |
|
You should add |
yerke
force-pushed
the
add-test-for-issue-37508
branch
from
9737c32
to
5d1a516
Compare
|
@JohnTitor Thanks for the advice. Done. |
JohnTitor
reviewed
Jun 16, 2021
yerke
force-pushed
the
add-test-for-issue-37508
branch
from
5d1a516
to
a89c7e1
Compare
JohnTitor
approved these changes
Jun 18, 2021
|
@bors r+ rollup=iffy Past attempts to add tests here weren't particularly successful. |
|
📌 Commit a89c7e1 has been approved by |
bors
added
S-waiting-on-bors
fee1-dead
added a commit
to fee1-dead-contrib/rust
that referenced
this pull request
Jun 22, 2021
…ark-Simulacrum Add regression test for issue rust-lang#37508 Add regression test for issue rust-lang#37508 Closes rust-lang#37508 Took this test from rust-lang#37508 and updated the panic handler to the modern standard. r? `@Mark-Simulacrum` Mark, I hope you don't me tagging you here. You were involved in the original issue and I hope you might be more comfortable reviewing this.
|
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add regression test for issue #37508
Closes #37508
Took this test from #37508 and updated the panic handler to the modern standard.
r? @Mark-Simulacrum
Mark, I hope you don't me tagging you here. You were involved in the original issue and I hope you might be more comfortable reviewing this.