Rollup of 6 pull requests #87133
Merged
Rollup of 6 pull requests #87133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is leftover from when `doctest` used to be called `test`. Remove it now, it's unnecessary and makes the code harder to read.
expand: Support helper attributes for built-in derive macros This is needed for rust-lang#86735 (derive macro `Default` should have a helper attribute `default`). With this PR we can specify helper attributes for built-in derives using syntax `#[rustc_builtin_macro(MacroName, attributes(attr1, attr2, ...))]` which mirrors equivalent syntax for proc macros `#[proc_macro_derive(MacroName, attributes(attr1, attr2, ...))]`. Otherwise expansion infra was already ready for this. The attribute parsing code is shared between proc macro derives and built-in macros (`fn parse_macro_name_and_helper_attrs`).
…low, r=notriddle Fix codeblocks overflow Fixes rust-lang#87043. Instead of completely relying on `pulldown-cmark` (and its potential changes), I decided to move the generation of codeblocks HTML directly in rustdoc so we can unify the DOM and the CSS classes. r? `@Nemo157`
Shrink the CrateStore dynamic interface. The information is either accessible through queries or by crates which already depend on rustc_metadata.
rustdoc: Remove unnecessary `extern crate` aliases
…triddle Fix Ayu theme <code> color Fixes rust-lang#87072 (the second regression). r? `@notriddle`
…st, r=Mark-Simulacrum Update browser-ui-test package version It adds a check to prevent to have empty CSS values in `assert-css` command. r? `@Mark-Simulacrum`
|
@bors: r+ p=6 rollup=never |
|
📌 Commit ac6672b has been approved by |
bors
added
the
S-waiting-on-bors
|
⌛ Testing commit ac6672b with merge 10939d3bd175c9aaddc5feb5512e1bd1958adb68... |
|
A job failed! Check out the build log: (web) (plain) Click to see the possible cause of the failure (guessed by this bot) |
|
@bors retry |
|
⌛ Testing commit ac6672b with merge 085b7adca038fa545d3b0efc217dc74504fd09bd... |
|
@bors retry |
|
⌛ Testing commit ac6672b with merge 7f342a73c5652890f3aaf37ba97fbaa84362d469... |
|
@bors retry |
|
☀️ Test successful - checks-actions |
This was referenced Jul 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
extern cratealiases #87120 (rustdoc: Remove unnecessaryextern cratealiases)<code>color)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup