-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 11 pull requests #87333
Rollup of 11 pull requests #87333
Commits on Jul 10, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 05dcb78 - Browse repository at this point
Copy the full SHA 05dcb78View commit details -
Configuration menu - View commit details
-
Copy full SHA for b44be27 - Browse repository at this point
Copy the full SHA b44be27View commit details -
Configuration menu - View commit details
-
Copy full SHA for e276b86 - Browse repository at this point
Copy the full SHA e276b86View commit details
Commits on Jul 13, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 8c40360 - Browse repository at this point
Copy the full SHA 8c40360View commit details
Commits on Jul 16, 2021
-
Avoid collecting an interator just to re-iterate immediately. Rather reuse the previous iterator. (clippy::needless_collect)
Configuration menu - View commit details
-
Copy full SHA for 8462a37 - Browse repository at this point
Copy the full SHA 8462a37View commit details
Commits on Jul 17, 2021
-
Configuration menu - View commit details
-
Copy full SHA for abfd44d - Browse repository at this point
Copy the full SHA abfd44dView commit details
Commits on Jul 19, 2021
-
Configuration menu - View commit details
-
Copy full SHA for d05a286 - Browse repository at this point
Copy the full SHA d05a286View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4b82bbe - Browse repository at this point
Copy the full SHA 4b82bbeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7066398 - Browse repository at this point
Copy the full SHA 7066398View commit details -
Configuration menu - View commit details
-
Copy full SHA for d6dc840 - Browse repository at this point
Copy the full SHA d6dc840View commit details -
Configuration menu - View commit details
-
Copy full SHA for 76ab8a6 - Browse repository at this point
Copy the full SHA 76ab8a6View commit details -
Add comments explaining the unix command-line argument support.
Following up on rust-lang#87236, add comments to the unix command-line argument support explaining that the code doesn't mutate the system-provided argc/argv, and that this is why the code doesn't need a lock or special memory ordering.
Configuration menu - View commit details
-
Copy full SHA for 2a56a68 - Browse repository at this point
Copy the full SHA 2a56a68View commit details
Commits on Jul 20, 2021
-
Chinmay Deshpande authored
Jul 20, 2021 Configuration menu - View commit details
-
Copy full SHA for 64f4e34 - Browse repository at this point
Copy the full SHA 64f4e34View commit details -
It used to allow you to mutate the key, even though that can invalidate the map by creating duplicate keys.
Configuration menu - View commit details
-
Copy full SHA for b9b0a5e - Browse repository at this point
Copy the full SHA b9b0a5eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 75d9ed7 - Browse repository at this point
Copy the full SHA 75d9ed7View commit details -
Configuration menu - View commit details
-
Copy full SHA for df04b98 - Browse repository at this point
Copy the full SHA df04b98View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1ad1b94 - Browse repository at this point
Copy the full SHA 1ad1b94View commit details -
docs: GlobalAlloc: completely replace example with one that works
Since this is an example, this could really do with some review from someone familiar with unsafe stuff ! I made the example no longer `no_run` since it works for me. Fixes rust-lang#81847 Signed-off-by: Ian Jackson <[email protected]> Co-authored-by: Amanieu d'Antras <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 07e11e8 - Browse repository at this point
Copy the full SHA 07e11e8View commit details -
Resolve nested inference variables.
I attempted that with the previous code, but I misunderstdood how `shallow_resolve` works.
Configuration menu - View commit details
-
Copy full SHA for b3aca47 - Browse repository at this point
Copy the full SHA b3aca47View commit details -
Support HIR wf checking for function signatures
During function type-checking, we normalize any associated types in the function signature (argument types + return type), and then create WF obligations for each of the normalized types. The HIR wf code does not currently support this case, so any errors that we get have imprecise spans. This commit extends `ObligationCauseCode::WellFormed` to support recording a function parameter, allowing us to get the corresponding HIR type if an error occurs. Function typechecking is modified to pass this information during signature normalization and WF checking. The resulting code is fairly verbose, due to the fact that we can no longer normalize the entire signature with a single function call. As part of the refactoring, we now perform HIR-based WF checking for several other 'typed items' (statics, consts, and inherent impls). As a result, WF and projection errors in a function signature now have a precise span, which points directly at the responsible type. If a function signature is constructed via a macro, this will allow the error message to point at the code 'most responsible' for the error (e.g. a user-supplied macro argument).
Configuration menu - View commit details
-
Copy full SHA for db0324e - Browse repository at this point
Copy the full SHA db0324eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 713044c - Browse repository at this point
Copy the full SHA 713044cView commit details -
Use `/etc/os-release` instead of `/etc/NIXOS`. The latter one does not exist on NixOS when using tmpfs as root.
Configuration menu - View commit details
-
Copy full SHA for 919a8a5 - Browse repository at this point
Copy the full SHA 919a8a5View commit details
Commits on Jul 21, 2021
-
Rollup merge of rust-lang#81864 - ijackson:globalalloc-example, r=Ama…
…nieu docs: GlobalAlloc: completely replace example with one that works Since this is an example, this could really do with some review from someone familiar with unsafe stuff! I made the example no longer `no_run` since it works for me. Fixes rust-lang#81847
Configuration menu - View commit details
-
Copy full SHA for 9a888ea - Browse repository at this point
Copy the full SHA 9a888eaView commit details -
Rollup merge of rust-lang#86580 - BoxyUwU:cgd-subst-ice, r=nikomatsakis
dont provide fwd declared params to cg defaults Fixes rust-lang#83938 ```rust #![feature(const_evaluatable_checked, const_generics, const_generics_defaults)] #![allow(incomplete_features)] pub struct Bar<const N: usize, const M: usize = { N + 1 }>; pub fn foo<const N1: usize>() -> Bar<N1> { loop {} } fn main() {} ``` This PR makes this code no longer ICE, it was ICE'ing previously because when building substs for `Bar<N1>` we would subst the anon ct: `ConstKind::Unevaluated({N + 1}, substs: [N, M])` with substs of `[N1]`. the anon const has forward declared params supplied though so we end up trying to substitute the provided `M` param which causes the ICE. This PR doesn't handle the predicates of the const so ```rust trait Foo<const N: usize> { const Assoc: usize; } pub struct Bar<const N: usize = { <()>::Assoc }> where (): Foo<N>; ``` Resolves to `<() as Foo<N>>::Assoc` which can allow for using fwd declared params indirectly. ```rust trait Foo<const N: usize> {} struct Bar<const N: usize = { 2 + 3 }> where (): Foo<N>; ``` This code also ICEs under this PR because instantiating the default's predicates causes an ICE as predicates_of contains predicates with fwd declared params PR was briefly discussed [in this zulip thread](https://rust-lang.zulipchat.com/#narrow/stream/260443-project-const-generics/topic/evil.20preds.20in.20param.20env.20.2386580)
Configuration menu - View commit details
-
Copy full SHA for 2d05209 - Browse repository at this point
Copy the full SHA 2d05209View commit details -
Rollup merge of rust-lang#87187 - oxalica:fix-nixos-detect, r=nagisa
Fix NixOS detection Use `/etc/os-release` instead of `/etc/NIXOS` for detection. The latter one does not exist on NixOS when using tmpfs as root.
Configuration menu - View commit details
-
Copy full SHA for 2cc7e85 - Browse repository at this point
Copy the full SHA 2cc7e85View commit details -
Rollup merge of rust-lang#87206 - matthiaskrgr:clippy_collect, r=davi…
…dtwco avoid temporary vectors/reuse iterators Avoid collecting an interator just to re-iterate immediately. Rather reuse the previous iterator. (clippy::needless_collect)
Configuration menu - View commit details
-
Copy full SHA for 2fac195 - Browse repository at this point
Copy the full SHA 2fac195View commit details -
Rollup merge of rust-lang#87265 - Aaron1011:hir-wf-fn, r=estebank
Support HIR wf checking for function signatures During function type-checking, we normalize any associated types in the function signature (argument types + return type), and then create WF obligations for each of the normalized types. The HIR wf code does not currently support this case, so any errors that we get have imprecise spans. This commit extends `ObligationCauseCode::WellFormed` to support recording a function parameter, allowing us to get the corresponding HIR type if an error occurs. Function typechecking is modified to pass this information during signature normalization and WF checking. The resulting code is fairly verbose, due to the fact that we can no longer normalize the entire signature with a single function call. As part of the refactoring, we now perform HIR-based WF checking for several other 'typed items' (statics, consts, and inherent impls). As a result, WF and projection errors in a function signature now have a precise span, which points directly at the responsible type. If a function signature is constructed via a macro, this will allow the error message to point at the code 'most responsible' for the error (e.g. a user-supplied macro argument).
Configuration menu - View commit details
-
Copy full SHA for f4236cc - Browse repository at this point
Copy the full SHA f4236ccView commit details -
Rollup merge of rust-lang#87270 - GuillaumeGomez:item-summary-table, …
…r=notriddle Don't display <table> in item summary Fixes rust-lang#87231. r? `@notriddle`
Configuration menu - View commit details
-
Copy full SHA for a08e0bf - Browse repository at this point
Copy the full SHA a08e0bfView commit details -
Rollup merge of rust-lang#87273 - fee1-dead:impl-const-impl-bounds, r…
…=oli-obk Recognize bounds on impls as const bounds r? `@oli-obk`
Configuration menu - View commit details
-
Copy full SHA for 554987a - Browse repository at this point
Copy the full SHA 554987aView commit details -
Rollup merge of rust-lang#87278 - lnicola:rust-analyzer-2021-07-19, r…
…=lnicola ⬆️ rust-analyzer
Configuration menu - View commit details
-
Copy full SHA for 09e62b1 - Browse repository at this point
Copy the full SHA 09e62b1View commit details -
Rollup merge of rust-lang#87279 - sunfishcode:document-unix-argv, r=R…
…alfJung Add comments explaining the unix command-line argument support. Following up on rust-lang#87236, add comments to the unix command-line argument support explaining that the code doesn't mutate the system-provided argc/argv, and that this is why the code doesn't need a lock or special memory ordering. r? `@RalfJung`
Configuration menu - View commit details
-
Copy full SHA for 30c4f2f - Browse repository at this point
Copy the full SHA 30c4f2fView commit details -
Rollup merge of rust-lang#87287 - oli-obk:fixup_fixup_fixup_opaque_ty…
…pes, r=spastorino Make mir borrowck's use of opaque types independent of the typeck query's result fixes rust-lang#87218 fixes rust-lang#86465 we used to use the typeck results only to generate an obligation for the mir borrowck type to be equal to the typeck result. When i removed the `fixup_opaque_types` function in rust-lang#87200, I exposed a bug that showed that mir borrowck can't doesn't get enough information from typeck in order to build the correct lifetime mapping from opaque type usage to the actual concrete type. We therefor now fully compute the information within mir borrowck (we already did that, but we only used it to verify the typeck result) and stop using the typeck information. We will likely be able to remove most opaque type information from the borrowck results in the future and just have all current callers use the mir borrowck result instead. r? `@spastorino`
Configuration menu - View commit details
-
Copy full SHA for 1c60b82 - Browse repository at this point
Copy the full SHA 1c60b82View commit details -
Rollup merge of rust-lang#87301 - chinmaydd:chinmaydd-patch-1-1, r=jy…
…n514 Fix typo in compile.rs
Configuration menu - View commit details
-
Copy full SHA for 0141149 - Browse repository at this point
Copy the full SHA 0141149View commit details