Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Forbid inline const block referencing params from being used in patterns #88088

Merged
merged 2 commits into from
Aug 29, 2021
Merged

Forbid inline const block referencing params from being used in patterns #88088

merged 2 commits into from
Aug 29, 2021

Conversation

nbdd0121
Copy link
Contributor

@nbdd0121 nbdd0121 commented Aug 16, 2021 •
edited by nagisa
Loading

Fix #82518

@rust-highfive
Copy link
Collaborator

r? @nagisa

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 16, 2021
@nagisa
Copy link
Member

nagisa commented Aug 23, 2021

I was going to say:

Are we sure we want this to not work? From the language and surprise factor perspective I feel like this should work…

but then realised this is a pre-existing error condition anyway, so @bors r+. Thanks!

@nbdd0121
Copy link
Contributor Author

but then realised this is a pre-existing error condition anyway, so @bors r+. Thanks!

It seems that bors isn't triggered. It might have to be on its own line?

@inquisitivecrystal inquisitivecrystal added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Aug 24, 2021
@nagisa
Copy link
Member

nagisa commented Aug 28, 2021

@bors r+

@bors
Copy link
Contributor

bors commented Aug 28, 2021

📌 Commit dc52040 has been approved by nagisa

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 28, 2021
@bors
Copy link
Contributor

bors commented Aug 29, 2021

⌛ Testing commit dc52040 with merge 3a21a5b...

@bors
Copy link
Contributor

bors commented Aug 29, 2021

☀️ Test successful - checks-actions
Approved by: nagisa
Pushing 3a21a5b to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 29, 2021
@bors bors merged commit 3a21a5b into rust-lang:master Aug 29, 2021
@rustbot rustbot added this to the 1.56.0 milestone Aug 29, 2021
@bors bors mentioned this pull request Aug 29, 2021
Closed
@nbdd0121 nbdd0121 deleted the const2 branch September 4, 2021 02:54
@lcnr lcnr added the F-inline_const Inline constants (aka: const blocks, const expressions, anonymous constants) label Dec 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nagisa nagisa

Labels
F-inline_const Inline constants (aka: const blocks, const expressions, anonymous constants) merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.56.0
Development

Successfully merging this pull request may close these issues.

ICE with inline-const in match referencing const-generic parameter
7 participants
@nbdd0121 @rust-highfive @nagisa @bors @inquisitivecrystal @lcnr @rustbot