Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable unit tests in libstd and libextra on Windows #8819

Closed
wants to merge 4 commits into from

Conversation

vadimcn
Copy link
Contributor

@vadimcn vadimcn commented Aug 28, 2013

Some of the tests are failing. I've only managed to fix 'memory_map_file', the rest are up for grabs...

Fixes #5261.

@sanxiyn
Copy link
Member

sanxiyn commented Aug 28, 2013

Does it make sense to change check-fast to run std and extra tests? I thought check-fast was an alternative way to run rpass tests.

@vadimcn
Copy link
Contributor Author

vadimcn commented Aug 28, 2013

My understanding is that make check-fast is supposed to be a faster version of make check on platform(s) where process spawning is expensive. However, because of broken stack unwinding on Windows, only rpass tests were possible to be run in this way. This is no longer the case, and I'm trying to expand test coverage on Windows.

@brson
Copy link
Contributor

brson commented Aug 28, 2013

@sanxiyn From my perspective 'check-fast' is just the target we use on the windows bots, so if there are tests we want to run there then it's fine to include them.

@sanxiyn
Copy link
Member

sanxiyn commented Aug 29, 2013

@brson Shouldn't we rename the target to check-windows then?

@pnkfelix
Copy link
Member

Assuming this lands, it sounds like it will fix #5261 (at least partially, maybe not enough to close the ticket...)

I don't know if I would want to rename check-fast to check-windows. It might go away anyhow: maybe we'll adopt a different strategy e.g. dynamic loading (#458, #7027, #7095), and then remove it (#4193)

@pnkfelix
Copy link
Member

Also, regarding renaming check-fast to check-windows, there is active discussion of making not windows-specific; e.g. see Sully's suggestion on #8456.

bors added a commit that referenced this pull request Aug 29, 2013
Some of the tests are failing.  I've only managed to fix 'memory_map_file', the rest are up for grabs...

Fixes #5261.
@vadimcn
Copy link
Contributor Author

vadimcn commented Aug 29, 2013

Hmm, I don't think I've changed any non-windows code. Is there a way to get a callstack or something?

bors added a commit that referenced this pull request Aug 30, 2013
Some of the tests are failing.  I've only managed to fix 'memory_map_file', the rest are up for grabs...

Fixes #5261.
@bors bors closed this Aug 30, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bots are no longer testing core/std on windows
7 participants