-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WrappingRange
(#88242) follow-up (is_full_for
, Scalar: Copy
, etc.)
#88327
Conversation
Some changes occured to the CTFE / Miri engine cc @rust-lang/miri |
Reason for not having method in |
Thanks for the helpful reviews |
Just did a commit that makes |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Will be interesting to see if this fails because of performance or other reasons |
☔ The latest upstream changes (presumably #88337) made this pull request unmergeable. Please resolve the merge conflicts. |
906b5e1
to
bb77f75
Compare
Could I get a performance run for this one? |
Btw, you can probably avoid most of these CI failures that you got by running these commands before pushing
They should not take very long (a few minutes at most). |
@bors try @rust-timer queue |
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
⌛ Trying commit bb77f75121f73e5ddee51278d5aabc7d4bb9dec5 with merge b56cc0a2583497dfdb9f9f45cd7ff1f822e2f71f... |
☀️ Try build successful - checks-actions |
Queued b56cc0a2583497dfdb9f9f45cd7ff1f822e2f71f with parent 6cfa773, future comparison URL. |
Finished benchmarking try commit (b56cc0a2583497dfdb9f9f45cd7ff1f822e2f71f): comparison url. Summary: This benchmark run did not return any relevant changes. If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. @bors rollup=never |
Thanks for your tip, it will improve my life 👍 |
fix fix Remove more refs and clones fix more fix
d16829a
to
bc95994
Compare
rebased |
@bors r+ |
📌 Commit bc95994 has been approved by |
⌛ Testing commit bc95994 with merge c6e1ba0f0c5c92cb94e5b8369c6661656710c632... |
The job Click to see the possible cause of the failure (guessed by this bot)
|
💔 Test failed - checks-actions |
@bors retry Windows image update has broken things. |
☀️ Test successful - checks-actions |
Finished benchmarking commit (641e02f): comparison url. Summary: This benchmark run did not return any relevant changes. If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression |
Some changes related to feedback during #88242
r? @RalfJung