Revert "Disable the machine outliner by default" #88388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @wesleywiser (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
bjorn3
reviewed
Aug 27, 2021
| // bound. | ||
| if llvm_util::get_version() >= (11, 0, 0) { | ||
| add("-enable-machine-outliner=never", false); | ||
| } |
There was a problem hiding this comment.
What is the policy on this? Should the disable only be reverted for the rust fork of LLVM or LLVM 13 and up?
There was a problem hiding this comment.
I'd say disable for >= 11.0.0 && < 12.0.1
There was a problem hiding this comment.
Our fork of 12.0.1 doesn't contain the fix commit. https://github.com/rust-lang/llvm-project/tree/rustc/12.0-2021-07-10 So I changed the disabling range to >= 11.0.0 && < 13.0.0
|
@bors r+ rollup=never (in case there are more issues) |
|
📌 Commit bf2f665 has been approved by |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fix commit is already in the fork: rust-lang/llvm-project@6c78dbd4ca1f
Linked: