Fix LLVM libunwind build for non-musl targets #88483
Conversation
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
jethrogb
force-pushed
the
jb/llvm-libunwind-self-contained
branch
from
c58dcfb
to
446c429
Compare
|
cc @12101111
This was the initial set, but others could be added as well when reasonable. For example, does fortanix-sgx links to some kind of libc? |
No
Well I suppose you could always swap it out for something you build yourself if you provide the right interface? The only things required to build & link for this target is distributed by the Rust project, there are no other build dependencies and there are no other competing toolchains. |
|
I see. The choice probably doesn't matters from practical point of view, fortanix-sgx and fuchsia are targets for which we can change details like this at any moment, so it's mostly a matter of internal consistency right now. |
|
How to move forward on this? Nightly builds for this target have been broken for the better part of a week. |
|
r? @petrochenkov @bors r+ |
|
📌 Commit 446c429 has been approved by |
bors
added
S-waiting-on-bors
…tained, r=petrochenkov Fix LLVM libunwind build for non-musl targets Broken in rust-lang#85600. AFAICT, [only musl, mingw, and wasm](https://github.com/rust-lang/rust/blob/673d0db5e393e9c64897005b470bfeb6d5aec61b/compiler/rustc_target/src/spec/crt_objects.rs#L128-L132) should use the “self-contained” logic in rustbuild.
Rollup of 7 pull requests Successful merges: - rust-lang#88202 (Add an example for deriving PartialOrd on enums) - rust-lang#88483 (Fix LLVM libunwind build for non-musl targets) - rust-lang#88507 (Add test case for using `slice::fill` with MaybeUninit) - rust-lang#88557 (small const generics cleanup) - rust-lang#88579 (remove redundant / misplaced sentence from docs) - rust-lang#88610 (Update outdated docs of array::IntoIter::new.) - rust-lang#88613 (Update primitive docs for rust 2021.) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Broken in #85600. AFAICT, only musl, mingw, and wasm should use the “self-contained” logic in rustbuild.